Skip to content

Commit 7a1d8ab

Browse files
committed
clean up errors/warnings in windows workflows
1 parent fbbf397 commit 7a1d8ab

File tree

2 files changed

+32
-23
lines changed

2 files changed

+32
-23
lines changed

.github/workflows/conda-package-cf.yml

Lines changed: 22 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -103,10 +103,13 @@ jobs:
103103

104104
- uses: conda-incubator/setup-miniconda@fc2d68f6413eb2d87b895e92f8584b5b94a10167 # v3.3.0
105105
with:
106-
conda-remove-defaults: true
107-
channels: conda-forge
106+
miniforge-variant: Miniforge3
107+
miniforge-version: latest
108108
auto-activate: true
109109
activate-environment: base
110+
channels: conda-forge
111+
conda-remove-defaults: true
112+
python-version: ${{ matrix.python }}
110113

111114
- name: Cache conda packages
112115
uses: actions/cache@cdf6c1fa76f9f475f3d7449005a359c84ca0f306 # v5.0.3
@@ -123,14 +126,19 @@ jobs:
123126
- name: Install conda-build
124127
run: conda install -n base -y conda-build
125128

129+
- name: Store conda paths as envs
130+
shell: bash -el {0}
131+
run: |
132+
echo "CONDA_BLD=${CONDA_PREFIX}\\conda-bld\\win-64\\" >> "$GITHUB_ENV"
133+
126134
- name: Build conda package
127135
run: conda build --no-test --python ${{ matrix.python }} --numpy ${{ matrix.numpy }} -c conda-forge --override-channels conda-recipe-cf
128136

129137
- name: Upload artifact
130138
uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7.0.0
131139
with:
132140
name: ${{ env.PACKAGE_NAME }} ${{ runner.os }} Python ${{ matrix.python }}
133-
path: ${{ env.conda-bld }}${{ env.PACKAGE_NAME }}-*.conda
141+
path: ${{ env.CONDA_BLD }}${{ env.PACKAGE_NAME }}-*.conda
134142

135143
test_linux:
136144
needs: build_linux
@@ -243,20 +251,22 @@ jobs:
243251

244252
- uses: conda-incubator/setup-miniconda@fc2d68f6413eb2d87b895e92f8584b5b94a10167 # v3.3.0
245253
with:
246-
conda-remove-defaults: true
254+
miniforge-version: latest
247255
channels: conda-forge
248-
auto-activate: true
249-
activate-environment: base
256+
conda-remove-defaults: true
257+
activate-environment: ${{ env.TEST_ENV_NAME }}
258+
python-version: ${{ matrix.python }}
250259

251-
- name: Install conda-build
252-
# Needed to be able to run conda index
253-
run: conda install conda-build
260+
- name: Install conda-index
261+
run: |
262+
conda install conda-index
254263
255264
- name: Create conda channel
256265
run: |
257266
mkdir ${{ env.GITHUB_WORKSPACE }}\channel\win-64
258267
move ${{ env.PACKAGE_NAME }}-*.conda ${{ env.GITHUB_WORKSPACE }}\channel\win-64
259-
conda index ${{ env.GITHUB_WORKSPACE }}/channel
268+
python -m conda_index ${{ env.GITHUB_WORKSPACE }}/channel
269+
260270
# Test channel
261271
conda search ${{ env.PACKAGE_NAME }} -c ${{ env.GITHUB_WORKSPACE }}/channel --override-channels --info --json > ${{ env.GITHUB_WORKSPACE }}\ver.json
262272
more ${{ env.GITHUB_WORKSPACE }}\ver.json
@@ -270,8 +280,7 @@ jobs:
270280
FOR /F "tokens=* USEBACKQ" %%F IN (`python -c "%SCRIPT%"`) DO (
271281
SET PACKAGE_VERSION=%%F
272282
)
273-
conda create -n ${{ env.TEST_ENV_NAME }} ${{ env.PACKAGE_NAME }}=%PACKAGE_VERSION% python=${{ matrix.python }} numpy=${{ matrix.numpy }} -c ${{ env.GITHUB_WORKSPACE }}/channel ${{ env.CHANNELS }} --only-deps --dry-run > lockfile
274-
more lockfile
283+
conda install -n ${{ env.TEST_ENV_NAME }} ${{ env.PACKAGE_NAME }}=%PACKAGE_VERSION% python=${{ matrix.python }} numpy=${{ matrix.numpy }} -c ${{ env.GITHUB_WORKSPACE }}/channel ${{ env.CHANNELS }} --only-deps --dry-run > lockfile
275284
276285
- name: Cache conda packages
277286
uses: actions/cache@cdf6c1fa76f9f475f3d7449005a359c84ca0f306 # v5.0.3
@@ -300,5 +309,5 @@ jobs:
300309
301310
- name: Run tests
302311
run: |
303-
conda activate -n ${{ env.TEST_ENV_NAME }}
312+
conda activate ${{ env.TEST_ENV_NAME }}
304313
pytest -v --pyargs ${{ env.MODULE_NAME }}

.github/workflows/conda-package.yml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -247,19 +247,20 @@ jobs:
247247
- uses: conda-incubator/setup-miniconda@fc2d68f6413eb2d87b895e92f8584b5b94a10167 # v3.3.0
248248
with:
249249
miniforge-version: latest
250-
use-mamba: 'true'
251-
conda-remove-defaults: 'true'
252-
activate-environment: 'test'
253-
python-version: '3.13' # no python 3.14 support by conda-index
250+
channels: conda-forge
251+
conda-remove-defaults: true
252+
activate-environment: ${{ env.TEST_ENV_NAME }}
253+
python-version: ${{ matrix.python }}
254254

255255
- name: Install conda-index
256-
run: conda install conda-index
256+
run: |
257+
conda install conda-index
257258
258259
- name: Create conda channel
259260
run: |
260261
mkdir ${{ env.GITHUB_WORKSPACE }}\channel\win-64
261262
move ${{ env.PACKAGE_NAME }}-*.conda ${{ env.GITHUB_WORKSPACE }}\channel\win-64
262-
python -m conda_index "${{ env.GITHUB_WORKSPACE }}/channel"
263+
python -m conda_index ${{ env.GITHUB_WORKSPACE }}/channel
263264
264265
# Test channel
265266
conda search ${{ env.PACKAGE_NAME }} -c ${{ env.GITHUB_WORKSPACE }}/channel --override-channels --info --json > ${{ env.GITHUB_WORKSPACE }}\ver.json
@@ -274,8 +275,7 @@ jobs:
274275
FOR /F "tokens=* USEBACKQ" %%F IN (`python -c "%SCRIPT%"`) DO (
275276
SET PACKAGE_VERSION=%%F
276277
)
277-
conda create -n ${{ env.TEST_ENV_NAME }} ${{ env.PACKAGE_NAME }}=%PACKAGE_VERSION% python=${{ matrix.python }} numpy=${{ matrix.numpy }} -c ${{ env.GITHUB_WORKSPACE }}/channel ${{ env.CHANNELS }} --only-deps --dry-run > lockfile
278-
more lockfile
278+
conda install -n ${{ env.TEST_ENV_NAME }} ${{ env.PACKAGE_NAME }}=%PACKAGE_VERSION% python=${{ matrix.python }} numpy=${{ matrix.numpy }} -c ${{ env.GITHUB_WORKSPACE }}/channel ${{ env.CHANNELS }} --only-deps --dry-run > lockfile
279279
280280
- name: Cache conda packages
281281
uses: actions/cache@cdf6c1fa76f9f475f3d7449005a359c84ca0f306 # v5.0.3
@@ -302,12 +302,12 @@ jobs:
302302
)
303303
SET "WORKAROUND_DEPENDENCIES=intel-openmp"
304304
conda create -n ${{ env.TEST_ENV_NAME }} ${{ env.PACKAGE_NAME }}=%PACKAGE_VERSION% %WORKAROUND_DEPENDENCIES% pytest python=${{ matrix.python }} numpy=${{ matrix.numpy }} -c ${{ env.GITHUB_WORKSPACE }}/channel ${{ env.CHANNELS }}
305-
conda activate -n ${{ env.TEST_ENV_NAME }}
305+
conda activate ${{ env.TEST_ENV_NAME }}
306306
307307
# Test installed packages
308308
conda list
309309
310310
- name: Run tests
311311
run: |
312-
conda activate -n "${{ env.TEST_ENV_NAME }}"
312+
conda activate "${{ env.TEST_ENV_NAME }}"
313313
pytest -v --pyargs ${{ env.MODULE_NAME }}

0 commit comments

Comments
 (0)