Skip to content

Commit fb17e71

Browse files
committed
clean up errors/warnings in windows workflows
1 parent fbbf397 commit fb17e71

File tree

2 files changed

+22
-13
lines changed

2 files changed

+22
-13
lines changed

.github/workflows/conda-package-cf.yml

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -103,10 +103,13 @@ jobs:
103103

104104
- uses: conda-incubator/setup-miniconda@fc2d68f6413eb2d87b895e92f8584b5b94a10167 # v3.3.0
105105
with:
106-
conda-remove-defaults: true
107-
channels: conda-forge
106+
miniforge-variant: Miniforge3
107+
miniforge-version: latest
108108
auto-activate: true
109109
activate-environment: base
110+
channels: conda-forge
111+
conda-remove-defaults: true
112+
python-version: ${{ matrix.python }}
110113

111114
- name: Cache conda packages
112115
uses: actions/cache@cdf6c1fa76f9f475f3d7449005a359c84ca0f306 # v5.0.3
@@ -123,14 +126,19 @@ jobs:
123126
- name: Install conda-build
124127
run: conda install -n base -y conda-build
125128

129+
- name: Store conda paths as envs
130+
shell: bash -l {0}
131+
run: |
132+
echo "CONDA_BLD=$CONDA/conda-bld/win-64/" | tr "\\\\" '/' >> $GITHUB_ENV
133+
126134
- name: Build conda package
127135
run: conda build --no-test --python ${{ matrix.python }} --numpy ${{ matrix.numpy }} -c conda-forge --override-channels conda-recipe-cf
128136

129137
- name: Upload artifact
130138
uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7.0.0
131139
with:
132140
name: ${{ env.PACKAGE_NAME }} ${{ runner.os }} Python ${{ matrix.python }}
133-
path: ${{ env.conda-bld }}${{ env.PACKAGE_NAME }}-*.conda
141+
path: ${{ env.CONDA_BLD }}${{ env.PACKAGE_NAME }}-*.conda
134142

135143
test_linux:
136144
needs: build_linux
@@ -243,10 +251,11 @@ jobs:
243251

244252
- uses: conda-incubator/setup-miniconda@fc2d68f6413eb2d87b895e92f8584b5b94a10167 # v3.3.0
245253
with:
246-
conda-remove-defaults: true
254+
miniforge-version: latest
247255
channels: conda-forge
248-
auto-activate: true
249-
activate-environment: base
256+
conda-remove-defaults: true
257+
activate-environment: ${{ env.TEST_ENV_NAME }}
258+
python-version: ${{ matrix.python }}
250259

251260
- name: Install conda-build
252261
# Needed to be able to run conda index
@@ -300,5 +309,5 @@ jobs:
300309
301310
- name: Run tests
302311
run: |
303-
conda activate -n ${{ env.TEST_ENV_NAME }}
312+
conda activate ${{ env.TEST_ENV_NAME }}
304313
pytest -v --pyargs ${{ env.MODULE_NAME }}

.github/workflows/conda-package.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -247,10 +247,10 @@ jobs:
247247
- uses: conda-incubator/setup-miniconda@fc2d68f6413eb2d87b895e92f8584b5b94a10167 # v3.3.0
248248
with:
249249
miniforge-version: latest
250-
use-mamba: 'true'
251-
conda-remove-defaults: 'true'
252-
activate-environment: 'test'
253-
python-version: '3.13' # no python 3.14 support by conda-index
250+
channels: conda-forge
251+
conda-remove-defaults: true
252+
activate-environment: ${{ env.TEST_ENV_NAME }}
253+
python-version: ${{ matrix.python }}
254254

255255
- name: Install conda-index
256256
run: conda install conda-index
@@ -302,12 +302,12 @@ jobs:
302302
)
303303
SET "WORKAROUND_DEPENDENCIES=intel-openmp"
304304
conda create -n ${{ env.TEST_ENV_NAME }} ${{ env.PACKAGE_NAME }}=%PACKAGE_VERSION% %WORKAROUND_DEPENDENCIES% pytest python=${{ matrix.python }} numpy=${{ matrix.numpy }} -c ${{ env.GITHUB_WORKSPACE }}/channel ${{ env.CHANNELS }}
305-
conda activate -n ${{ env.TEST_ENV_NAME }}
305+
conda activate ${{ env.TEST_ENV_NAME }}
306306
307307
# Test installed packages
308308
conda list
309309
310310
- name: Run tests
311311
run: |
312-
conda activate -n "${{ env.TEST_ENV_NAME }}"
312+
conda activate "${{ env.TEST_ENV_NAME }}"
313313
pytest -v --pyargs ${{ env.MODULE_NAME }}

0 commit comments

Comments
 (0)