Revise SVR dataset scope and address uncaught errors#208
Revise SVR dataset scope and address uncaught errors#208ethanglaser wants to merge 5 commits intoIntelPython:mainfrom
Conversation
|
@avolkov-intel I recall you also wanted to make changes like these - would this PR create some conflict later on? |
| "1st run time[ms]": res["time[ms]"][0], | ||
| "1st-mean run ratio": res["time[ms]"][0] / mean, | ||
| "time[ms]": mean, | ||
| "time CV": std / mean, # Coefficient of Variation |
There was a problem hiding this comment.
It's very confusing to have a measurement called "time CV" reflecting the coefficient of variation when we also have procedures doing cross validation there. Also note that this is not actually the coefficient of variation due to the "boxed" methodology.
Perhaps could output just the standard deviation and name it 'std[ms]'. Or otherwise maybe could name it "std to mean (ratio)".
There was a problem hiding this comment.
I don't disagree with you, in fact for the large-scale branch that we have for multi-gpu we use std instead of CV. But I suggest revising this in a different PR as I did not change the logic here - the only reason the diff shows is because there was a condition added. Scope of this PR is resolving slowdowns/errors/failures and improving stability of CI jobs.
| res.update( | ||
| { | ||
| "1st run time[ms]": res["time[ms]"][0], | ||
| "1st-mean run ratio": res["time[ms]"][0] / mean, |
There was a problem hiding this comment.
Is it possible to have mean == 0 here?
| "1st-mean run ratio": res["time[ms]"][0] / mean, | |
| "1st-mean run ratio": res["time[ms]"][0] / mean if mean != 0 else res["time[ms]"][0], |
There was a problem hiding this comment.
If the mean runtime is 0 then we have larger problems than a divide by zero. But I did not update the logic here (see main branch), the diff only shows because I added an additional condition (if isinstance(res["time[ms]"], list):). There is no diff within this condition.
Description
AttributeError: 'float' object has no attribute 'sort'CI status: http://intel-ci.intel.com/f13777e8-38d3-f195-8d41-a4bf010d0e2d
Checklist:
Completeness and readability
Testing