feat: add upstream's trim command (EngineHub/WorldEdit#2278)#3168
Merged
NotMyFault merged 1 commit intoIntellectualSites:mainfrom Apr 8, 2025
Merged
Conversation
* Add the trim command * Fix issues from PR review * Cleanup usages of deprecated Vector getters * chore: cleanup translations & memoize mask --------- Co-authored-by: Madeline Miller <mnmiller1@me.com>
Member
PierreSchwang
left a comment
PierreSchwang
left a comment
There was a problem hiding this comment.
Generally fine with me - but I feel like all those loops would be perfect fits for MutableBlockVector3's
SirYwell
approved these changes
Apr 8, 2025
Member
SirYwell
left a comment
SirYwell
left a comment
There was a problem hiding this comment.
Looks good. I'd suggest to apply any improvements separately.
Contributor
Author
You mean with a separate commit or pr? |
Member
In a separate PR. |
PierreSchwang
approved these changes
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the trim command
Fix issues from PR review
Cleanup usages of deprecated Vector getters
chore: cleanup translations & memoize mask
Overview
Fixes EngineHub/WorldEdit#1629
Description
Adds upstream's
//trimcommand.Submitter Checklist