Skip to content

Fully replace ThreadLocal in Request with CHM#3251

Merged
NotMyFault merged 1 commit intomainfrom
perf/avoid-tl
Jul 29, 2025
Merged

Fully replace ThreadLocal in Request with CHM#3251
NotMyFault merged 1 commit intomainfrom
perf/avoid-tl

Conversation

@SirYwell
Copy link
Copy Markdown
Member

Overview

Description

I've seen multiple Spark profiles now where the ThreadLocal lookups added significant overhead. We don't actually need it because we already maintain a ConcurrentHashMap with the same information.

Submitter Checklist

  • Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
  • Ensure that the pull request title represents the desired changelog entry.
  • New public fields and methods are annotated with @since TODO.
  • I read and followed the contribution guidelines.

@SirYwell SirYwell requested a review from a team as a code owner July 28, 2025 18:13
@NotMyFault NotMyFault merged commit 844a1d2 into main Jul 29, 2025
9 checks passed
@NotMyFault NotMyFault deleted the perf/avoid-tl branch July 29, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants