fix: correct lazycopy dimensions and world usage#3520
Conversation
dordsor21
commented
May 10, 2026
dordsor21
commented
- fixes //lazycopy dimensiona too large #3472
- fixes LAZYCOPY will not copy clipboard source world #3496
|
|
||
| @Override | ||
| public long getMaxSize() { | ||
| return -1; |
There was a problem hiding this comment.
Why not just use Long.MAX_VALUE? The specification of the method in the superclass should also cover which values are valid.
There was a problem hiding this comment.
I wanted to convey actually unlimited rather than functionally unlimited. It should go into the javadoc though yeah
| * | ||
| * @return maximum size in blocks of this clipboard implementation. | ||
| */ | ||
| public long getMaxSize() { |
There was a problem hiding this comment.
An instance method is somehow the wrong approach, mainly because it requires an escaping this in the constructor, and it also doesn't have any different use really. Maybe SimpleClipboard is generally a rather problematic abstraction?
There was a problem hiding this comment.
It is, but altering the hierarchy is rather a v3 change and it would be nice to have this working a little sooner than that... We could always deprecate for removal upon implementation and put the change into V3 immediately.
Alternatively I suppose we could just reimplement in a different class entirely? Certainly the clipboard hierarchy could do with some cleanup at some point regardless
2 participants
