Skip to content

fix: correct tab completion for /plot flag set <flag> <value> #4698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jvstinxz wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: correct tab completion for /plot flag set <flag> <value> #4698

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e249605
fix: correct tab completion for /plot f set <flag> <value>
jvstinxz Jul 18, 2025
55db679
Support command abbreviations in tab completion
jvstinxz Jul 20, 2025
ac12ade
Merge branch 'IntellectualSites:main' into fix/plot-flag-tab-completion
jvstinxz Jul 20, 2025
68e4581
Merge branch 'main' into fix/plot-flag-tab-completion
jvstinxz Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Core/src/main/java/com/plotsquared/core/command/FlagCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,14 +268,14 @@ public Collection<Command> tab(
.filter(value -> value.startsWith(args[0].toLowerCase(Locale.ENGLISH)))
.map(value -> new Command(null, false, value, "", RequiredType.NONE, null) {
}).collect(Collectors.toList());
} else if (Arrays.asList("set", "add", "remove", "delete", "info")
} else if (Arrays.asList("set", "s", "add", "a", "remove", "r", "delete", "info", "i")
Copy link
Copy Markdown
Member

@dordsor21 dordsor21 Jul 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'd like to see these extracted to static final Collections.immutableSet at the class level - this would be best practices for Java. The args.length == # should be moved -- it is unlikely for these operations to be reordered

.contains(args[0].toLowerCase(Locale.ENGLISH)) && args.length == 2) {
return GlobalFlagContainer.getInstance().getRecognizedPlotFlags().stream()
.filter(flag -> !(flag instanceof InternalFlag))
.filter(flag -> flag.getName().startsWith(args[1].toLowerCase(Locale.ENGLISH)))
.map(flag -> new Command(null, false, flag.getName(), "", RequiredType.NONE, null) {
}).collect(Collectors.toList());
} else if (Arrays.asList("set", "add", "remove", "delete")
} else if (Arrays.asList("set", "s", "add", "a", "remove", "r", "delete")
.contains(args[0].toLowerCase(Locale.ENGLISH)) && args.length == 3) {
try {
final PlotFlag<?, ?> flag =
Expand Down Expand Up @@ -314,7 +314,7 @@ public Collection<Command> tab(
} catch (final Exception ignored) {
}
}
return tabOf(player, args, space);
return Collections.emptyList();
}

@CommandDeclaration(command = "set",
Expand Down
Loading