fix: use invariant culture for vary-by ETag formatting#733
Merged
Conversation
Generate invariant-culture formatting when converting non-string vary-by values to bytes for ETag computation to avoid culture-dependent hashes in generated controllers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Culture-sensitive
ToString()in generated controllers can produce different vary-by ETag values depending on server culture. This makes cache validation inconsistent for non-string vary-by properties.This change updates API controller generation to format non-string vary-by values with
CultureInfo.InvariantCulturebefore UTF-8 encoding, so ETag computation is stable across cultures. It preserves existing behavior for byte-array and string vary-by properties and adds a changelog entry for the fix.