Fixes nullability of GetDisplayName return type#748
Merged
Conversation
The GetDisplayName extension method was marked as returning a nullable string, but the implementation always returns a string (falling back to the enum member name if no DisplayAttribute is present).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Corrects the return type of the enum display name helper to reflect that it always returns a non-nullable string. This aligns the method signature with its actual behavior and cleans up unnecessary using directives.
Fixes #Issue_Number (if available)
Ensure that your pull request has followed all the steps below: