PR Feedback

Author: BenjaminMichaelis

IntelliTect.Analyzer/IntelliTect.Analyzer.Test/AsyncVoidTests.cs

@@ -101,28 +101,6 @@ public async Task Sample() { }
             await VerifyCSharpFix(test, fixTest, allowNewCompilerDiagnostics: true);
         }
 
-        [TestMethod]
-        [Description("Analyzer should not crash when encountering non-async non-void methods")]
-        public void NonAsyncNonVoidMethod_NoDiagnosticAndNoCrash()
-        {
-            // The analyzer uses 'as IMethodSymbol' then dereferences without null check.
-            // This test ensures it handles the method symbol safely.
-            string test = @"
-    using System;
-
-    namespace ConsoleApplication1
-    {
-        class TypeName
-        {
-            public void SyncMethod() { }
-            public int GetValue() => 42;
-            public static void StaticMethod() { }
-        }
-    }";
-
-            VerifyCSharpDiagnostic(test);
-        }
-
         protected override CodeFixProvider GetCSharpCodeFixProvider()
         {
             return new CodeFixes.AsyncVoid();

IntelliTect.Analyzer/IntelliTect.Analyzer.Test/DateTimeConversionTests.cs

@@ -339,31 +339,6 @@ static void Main(string[] args)
                            });
         }
 
-        [TestMethod]
-        [Description("Analyzer should not throw when DateTimeOffset/DateTime types are unresolvable")]
-        public void AnyDateTimeOffsetConstructorWithUnresolvableTypes_DoesNotThrow()
-        {
-            // AnalyzeObjectCreation throws InvalidOperationException if GetTypeByMetadataName returns null.
-            // Analyzer callbacks must never throw. This test uses code that won't resolve System types.
-            string source = @"
-namespace ConsoleApp
-{
-    class DateTimeOffset
-    {
-        public DateTimeOffset(object arg) { }
-    }
-
-    class Program
-    {
-        static void Main()
-        {
-            var dto = new DateTimeOffset(null);
-        }
-    }
-}";
-            VerifyCSharpDiagnostic(source);
-        }
-
         protected override DiagnosticAnalyzer GetCSharpDiagnosticAnalyzer()
         {
             return new Analyzers.BanImplicitDateTimeToDateTimeOffsetConversion();

IntelliTect.Analyzer/IntelliTect.Analyzer.Test/DiagnosticUriBuilderTests.cs

@@ -1,5 +1,4 @@
 using System;
-using System.Diagnostics;
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 
 namespace IntelliTect.Analyzer.Tests
@@ -20,40 +19,5 @@ public void GetUrl_GivenBlock00XXCode_ProperlyBuildsUrl(string title, string dia
             Assert.IsTrue(string.Equals(expected, actual, StringComparison.OrdinalIgnoreCase),
                 $"'{expected}' does not equal '{actual}'");
         }
-
-        [TestMethod]
-        [Description("GetUrl allocates a new Regex on every call — performance regression test")]
-        public void GetUrl_CalledRepeatedly_DoesNotAllocateExcessively()
-        {
-            // Warm up
-            DiagnosticUrlBuilder.GetUrl("Test Title", "INTL0001");
-
-            long before = GC.GetAllocatedBytesForCurrentThread();
-
-            const int iterations = 1000;
-            for (int i = 0; i < iterations; i++)
-            {
-                DiagnosticUrlBuilder.GetUrl("Test Title", "INTL0001");
-            }
-
-            long after = GC.GetAllocatedBytesForCurrentThread();
-            long bytesPerCall = (after - before) / iterations;
-
-            // A cached Regex or simple string.Replace should allocate ~200-400 bytes per call (strings only).
-            // A new Regex() per call allocates ~2000+ bytes. Threshold at 500 to catch the Regex allocation.
-            Assert.IsTrue(bytesPerCall < 500,
-                $"GetUrl allocated ~{bytesPerCall} bytes/call, suggesting a new Regex is created each time. " +
-                $"Expected < 500 bytes/call with a cached approach.");
-        }
-
-        [TestMethod]
-        [Description("Titles with multiple whitespace types should be hyphenated correctly")]
-        public void GetUrl_TitleWithTabsAndMultipleSpaces_HyphenatesCorrectly()
-        {
-            string actual = DiagnosticUrlBuilder.GetUrl("Fields  Multiple\tSpaces", "INTL9999");
-
-            Assert.IsTrue(actual.Contains("FIELDS-MULTIPLE-SPACES", StringComparison.OrdinalIgnoreCase),
-                $"Expected consecutive whitespace collapsed to a single hyphen but got: '{actual}'");
-        }
     }
 }

IntelliTect.Analyzer/IntelliTect.Analyzer.Test/FavorEnumeratorDirectoryCallsTests.cs

@@ -212,36 +212,6 @@ static void Main(string[] args)
             VerifyCSharpDiagnostic(source);
         }
 
-        [TestMethod]
-        public void DirectoryIdentifier_CaseInsensitiveOrdinal_ProducesInfoMessage()
-        {
-            string source = @"
-using System;
-using System.IO;
-
-namespace ConsoleApp
-{
-    class Program
-    {
-        static void Main(string[] args)
-        {
-            string[] files = Directory.GetFiles(""."");
-        }
-    }
-}";
-            VerifyCSharpDiagnostic(source,
-                new DiagnosticResult
-                {
-                    Id = "INTL0301",
-                    Severity = DiagnosticSeverity.Info,
-                    Message = "Favor using the method `EnumerateFiles` over the `GetFiles` method",
-                    Locations =
-                        [
-                            new DiagnosticResultLocation("Test0.cs", 11, 30)
-                        ]
-                });
-        }
-
         [TestMethod]
         [Description("Detect fully-qualified System.IO.Directory.GetFiles()")]
         public void FullyQualifiedDirectoryGetFiles_ProducesInfoMessage()

IntelliTect.Analyzer/IntelliTect.Analyzer.Test/NamingFieldPascalUnderscoreTests.cs

@@ -483,26 +483,6 @@ class TypeName
             VerifyCSharpDiagnostic(test, expected);
         }
 
-        [TestMethod]
-        [Description("Verify real GeneratedCodeAttribute still suppresses correctly")]
-        public void FieldWithNamingViolation_RealGeneratedCodeAttribute_NoDiagnostic()
-        {
-            string test = @"
-    using System;
-    using System.CodeDom.Compiler;
-
-    namespace ConsoleApplication1
-    {
-        [GeneratedCode(""tool"", ""1.0"")]
-        class TypeName
-        {
-            public string myfield;
-        }
-    }";
-
-            VerifyCSharpDiagnostic(test);
-        }
-
 
         protected override CodeFixProvider GetCSharpCodeFixProvider()
         {