PR Feedback

Author: BenjaminMichaelis

IntelliTect.Analyzer/IntelliTect.Analyzer.Test/AttributesOnSeparateLinesTests.cs

@@ -394,8 +394,6 @@ static void Main()
         [Description("Analyzer should not report on generated code")]
         public void AttributesOnSameLine_InGeneratedCode_NoDiagnostic()
         {
-            // AttributesOnSeparateLines uses GeneratedCodeAnalysisFlags.Analyze | ReportDiagnostics,
-            // meaning it reports inside generated code. It should skip generated code.
             string test = @"using System;
 using System.CodeDom.Compiler;
 

IntelliTect.Analyzer/IntelliTect.Analyzer.Test/DiagnosticUriBuilderTests.cs

@@ -52,8 +52,8 @@ public void GetUrl_TitleWithTabsAndMultipleSpaces_HyphenatesCorrectly()
         {
             string actual = DiagnosticUrlBuilder.GetUrl("Fields  Multiple\tSpaces", "INTL9999");
 
-            Assert.IsTrue(actual.Contains("FIELDS--MULTIPLE-SPACES", StringComparison.OrdinalIgnoreCase),
-                $"Expected all whitespace replaced with hyphens but got: '{actual}'");
+            Assert.IsTrue(actual.Contains("FIELDS-MULTIPLE-SPACES", StringComparison.OrdinalIgnoreCase),
+                $"Expected consecutive whitespace collapsed to a single hyphen but got: '{actual}'");
         }
     }
 }

IntelliTect.Analyzer/IntelliTect.Analyzer.Test/FavorEnumeratorDirectoryCallsTests.cs

@@ -213,11 +213,8 @@ static void Main(string[] args)
         }
 
         [TestMethod]
-        [Description("Identifier comparison should use OrdinalIgnoreCase, not CurrentCultureIgnoreCase")]
         public void DirectoryIdentifier_CaseInsensitiveOrdinal_ProducesInfoMessage()
         {
-            // Verifies that an oddly-cased but valid Directory.GetFiles call is still caught.
-            // CurrentCultureIgnoreCase could fail in Turkish locale for identifiers with 'I'.
             string source = @"
 using System;
 using System.IO;
@@ -246,11 +243,9 @@ static void Main(string[] args)
         }
 
         [TestMethod]
-        [Description("Analyzer misses fully-qualified System.IO.Directory.GetFiles()")]
+        [Description("Detect fully-qualified System.IO.Directory.GetFiles()")]
         public void FullyQualifiedDirectoryGetFiles_ProducesInfoMessage()
         {
-            // The analyzer only checks IdentifierNameSyntax, so System.IO.Directory.GetFiles()
-            // is missed because the expression is a MemberAccessExpressionSyntax, not IdentifierNameSyntax.
             string source = @"
 using System;
 
@@ -278,7 +273,7 @@ static void Main(string[] args)
         }
 
         [TestMethod]
-        [Description("Analyzer misses fully-qualified System.IO.Directory.GetDirectories()")]
+        [Description("Detect fully-qualified System.IO.Directory.GetDirectories()")]
         public void FullyQualifiedDirectoryGetDirectories_ProducesInfoMessage()
         {
             string source = @"

IntelliTect.Analyzer/IntelliTect.Analyzer.Test/NamingFieldPascalUnderscoreTests.cs

@@ -1,4 +1,3 @@
-using System.Linq;
 using System.Threading.Tasks;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CodeFixes;
@@ -453,11 +452,9 @@ class TypeName
         }
 
         [TestMethod]
-        [Description("GeneratedCodeAttribute is checked by Name only, not full type — custom attribute with same name suppresses incorrectly")]
+        [Description("Custom GeneratedCodeAttribute in different namespace should not suppress diagnostics")]
         public void FieldWithNamingViolation_CustomGeneratedCodeAttribute_ShouldStillWarn()
         {
-            // A user-defined GeneratedCodeAttribute (different namespace) should NOT
-            // suppress the naming diagnostic, but the current code checks by Name only.
             string test = @"
     using System;
 

IntelliTect.Analyzer/IntelliTect.Analyzer.Test/UnusedLocalVariableTests.cs

@@ -9,18 +9,6 @@ namespace IntelliTect.Analyzer.Tests
     [TestClass]
     public class UnusedLocalVariableTests : CodeFixVerifier
     {
-        [TestMethod]
-        [Description("HelpLinkUri should use DiagnosticUrlBuilder, not a hardcoded generic URL")]
-        public void Descriptor_HelpLinkUri_ShouldBeSpecific()
-        {
-            DiagnosticAnalyzer analyzer = GetCSharpDiagnosticAnalyzer();
-            DiagnosticDescriptor diagnostic = analyzer.SupportedDiagnostics.Single();
-
-            string expectedUrl = DiagnosticUrlBuilder.GetUrl("Local variable unused", "INTL0303");
-            Assert.AreEqual(expectedUrl, diagnostic.HelpLinkUri,
-                $"HelpLinkUri should use DiagnosticUrlBuilder but was '{diagnostic.HelpLinkUri}'");
-        }
-
         [TestMethod]
         public void InstanceMemberAccessedOnLocalVariable_NoDiagnosticInformationReturned()
         {
@@ -262,11 +250,9 @@ bool Bar(Func<bool, bool> func)
         }
 
         [TestMethod]
-        [Description("Analyzer reports on generated code but should skip it")]
+        [Description("Analyzer should skip generated code")]
         public void UnusedLocalVariable_InGeneratedCode_NoDiagnostic()
         {
-            // UnusedLocalVariable uses GeneratedCodeAnalysisFlags.Analyze | ReportDiagnostics,
-            // meaning it reports inside generated code. It should use None to skip generated code.
             string test = @"
 using System;
 using System.CodeDom.Compiler;

IntelliTect.Analyzer/IntelliTect.Analyzer/Analyzers/FavorDirectoryEnumerationCalls.cs

@@ -87,10 +87,7 @@ private static bool IsDirectoryExpression(ExpressionSyntax expression, SyntaxNod
             // For fully-qualified expressions like 'System.IO.Directory'
             if (expression is MemberAccessExpressionSyntax)
             {
-                ISymbol resolvedSymbol = symbolInfo.Symbol
-                    ?? (symbolInfo.CandidateSymbols.Length > 0 ? symbolInfo.CandidateSymbols[0] : null);
-
-                if (resolvedSymbol is INamedTypeSymbol namedType)
+                if (symbolInfo.Symbol is INamedTypeSymbol namedType)
                 {
                     return namedType.OriginalDefinition
                         .ToDisplayString(SymbolDisplayFormat.FullyQualifiedFormat) == "global::System.IO.Directory";

IntelliTect.Analyzer/IntelliTect.Analyzer/DiagnosticUrlBuilder.cs

@@ -3,9 +3,10 @@
 
 namespace IntelliTect.Analyzer
 {
-    public static partial class DiagnosticUrlBuilder
+    public static class DiagnosticUrlBuilder
     {
         private const string BaseUrl = "https://github.com/IntelliTect/CodingGuidelines";
+        private static readonly Regex _HyphenateRegex = new(@"\s+", RegexOptions.Compiled);
 
         /// <summary>
         /// Get the full diagnostic help url
@@ -21,12 +22,9 @@ public static string GetUrl(string title, string diagnosticId)
             if (string.IsNullOrWhiteSpace(diagnosticId))
                 throw new System.ArgumentException("diagnostic ID cannot be empty", nameof(diagnosticId));
 
-            string hyphenatedTitle = HyphenateRegex().Replace(title, "-");
+            string hyphenatedTitle = _HyphenateRegex.Replace(title, "-");
 
             return BaseUrl + $"#{diagnosticId.ToUpperInvariant()}" + $"---{hyphenatedTitle.ToUpperInvariant()}";
         }
-
-        [GeneratedRegex(@"\s", RegexOptions.Compiled)]
-        private static partial Regex HyphenateRegex();
     }
 }