Commit 148b516
committed
fix: scope disposal guard to SQLite connections only, not base disposal
The shared _disposed flag was blocking base.Dispose(bool) when DisposeAsync
ran first — the base's async path may call Dispose(true), which our guard
intercepted, skipping base resource cleanup.
Fix: use a _connectionsDisposed flag that only gates the SQLite connection
cleanup (which we own). Base disposal calls are always forwarded. Also
removes the redundant GC.SuppressFinalize — the base class handles it.
Addresses Copilot PR review comments.1 parent 756a93d commit 148b516
1 file changed
Lines changed: 5 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
79 | | - | |
| 79 | + | |
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
83 | | - | |
84 | 83 | | |
85 | | - | |
| 84 | + | |
86 | 85 | | |
87 | | - | |
| 86 | + | |
| 87 | + | |
88 | 88 | | |
89 | | - | |
90 | 89 | | |
91 | 90 | | |
92 | 91 | | |
93 | 92 | | |
94 | | - | |
95 | 93 | | |
96 | | - | |
| 94 | + | |
97 | 95 | | |
98 | 96 | | |
99 | | - | |
100 | 97 | | |
101 | | - | |
102 | 98 | | |
103 | 99 | | |
104 | 100 | | |
0 commit comments