Skip to content

Commit a367dc9

Browse files
Update to C# 14 and move suppressions to Directory.Build.props
- Update LangVersion from 13 to 14 - Remove NoWarn suppressions from individual csproj files - Add WarningsNotAsErrors for NU1902, NU1903, CA1873 in Directory.Build.props - This follows Microsoft's recommended approach for projects using TreatWarningsAsErrors Co-authored-by: BenjaminMichaelis <22186029+BenjaminMichaelis@users.noreply.github.com>
1 parent 5c0a65a commit a367dc9

3 files changed

Lines changed: 4 additions & 7 deletions

File tree

Directory.Build.props

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
<Project>
22
<PropertyGroup>
33
<Nullable>enable</Nullable>
4-
<LangVersion>13</LangVersion>
4+
<LangVersion>14</LangVersion>
55
<AnalysisMode>Recommended</AnalysisMode>
66
<ImplicitUsings>enable</ImplicitUsings>
77
<PreserveCompilationContext>true</PreserveCompilationContext>
88
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
99
<DockerDefaultTargetOS>Linux</DockerDefaultTargetOS>
10-
<!-- CA1873: Suppress logging performance analyzer in .NET 10 for minor perf gains -->
11-
<NoWarn>$(NoWarn);CA1873</NoWarn>
10+
<!-- Exclude NuGet audit and analyzer warnings from being treated as errors -->
11+
<WarningsNotAsErrors>$(WarningsNotAsErrors);NU1902;NU1903;CA1873</WarningsNotAsErrors>
1212

1313
<!-- https://aka.ms/vs-build-acceleration -->
1414
<AccelerateBuildsInVisualStudio>True</AccelerateBuildsInVisualStudio>

EssentialCSharp.Web.Tests/EssentialCSharp.Web.Tests.csproj

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,8 @@
77
<IsPublishable>false</IsPublishable>
88
<!--
99
CA1707, Identifiers should not contain underscores - we allow these in test names
10-
NU1902/NU1903, Suppress vulnerability warnings for transitive dependencies from design-time tools
1110
-->
12-
<NoWarn>$(NoWarn);CA1707;NU1902;NU1903</NoWarn>
11+
<NoWarn>$(NoWarn);CA1707</NoWarn>
1312
</PropertyGroup>
1413

1514
<ItemGroup>

EssentialCSharp.Web/EssentialCSharp.Web.csproj

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
<Project Sdk="Microsoft.NET.Sdk.Web">
22
<PropertyGroup>
33
<TargetFramework>net10.0</TargetFramework>
4-
<!-- NU1902/NU1903, Suppress vulnerability warnings for transitive dependencies from design-time tools -->
5-
<NoWarn>$(NoWarn);NU1902;NU1903</NoWarn>
64
</PropertyGroup>
75
<ItemGroup>
86
<PlaceholderChapterOneHtmlFile Include="$(ProjectDir)/Placeholders/Chapters/01/Pages/*.html" />

0 commit comments

Comments
 (0)