Apply suggestions from code review

BenjaminMichaelis · Keboo · web-flow · commit a94adbef4934 · 2025-07-31T12:37:50.000-07:00
Co-authored-by: Kevin B &lt;Keboo@users.noreply.github.com&gt;
diff --git a/EssentialCSharp.Chat.Shared/EssentialCSharp.Chat.Common.csproj b/EssentialCSharp.Chat.Shared/EssentialCSharp.Chat.Common.csproj
@@ -2,8 +2,6 @@
 
   <PropertyGroup>
     <TargetFramework>net9.0</TargetFramework>
-    <ImplicitUsings>enable</ImplicitUsings>
-    <Nullable>enable</Nullable>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/EssentialCSharp.Chat.Shared/Services/AIChatService.cs b/EssentialCSharp.Chat.Shared/Services/AIChatService.cs
@@ -105,7 +105,7 @@ public AIChatService(IOptions<AIOptions> options, AISearchService searchService)
     /// </summary>
     private async Task<string> EnrichPromptWithContext(string prompt, bool enableContextualSearch, CancellationToken cancellationToken)
     {
-        if (!enableContextualSearch || _SearchService == null)
+        if (!enableContextualSearch)
         {
             return prompt;
         }
diff --git a/EssentialCSharp.Chat.Shared/Services/FileChunkingResult.cs b/EssentialCSharp.Chat.Shared/Services/FileChunkingResult.cs
@@ -9,6 +9,6 @@ public class FileChunkingResult
     public string FilePath { get; set; } = string.Empty;
     public int OriginalCharCount { get; set; }
     public int ChunkCount { get; set; }
-    public List<string> Chunks { get; set; } = new();
+    public List<string> Chunks { get; set; } = [];
     public int TotalChunkCharacters { get; set; }
 }
diff --git a/EssentialCSharp.Chat.Tests/EssentialCSharp.Chat.Tests.csproj b/EssentialCSharp.Chat.Tests/EssentialCSharp.Chat.Tests.csproj
@@ -2,8 +2,6 @@
 
   <PropertyGroup>
     <TargetFramework>net9.0</TargetFramework>
-    <ImplicitUsings>enable</ImplicitUsings>
-    <Nullable>enable</Nullable>
     <IsPackable>false</IsPackable>
   </PropertyGroup>
 
diff --git a/EssentialCSharp.VectorDbBuilder/EssentialCSharp.VectorDbBuilder.csproj b/EssentialCSharp.VectorDbBuilder/EssentialCSharp.VectorDbBuilder.csproj
@@ -3,8 +3,6 @@
   <PropertyGroup>
     <OutputType>Exe</OutputType>
     <TargetFramework>net9.0</TargetFramework>
-    <ImplicitUsings>enable</ImplicitUsings>
-    <Nullable>enable</Nullable>
   </PropertyGroup>
 
   <ItemGroup>
@@ -22,10 +20,7 @@
   </ItemGroup>
 
   <ItemGroup>
-    <None Update="appsettings.json">
-      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
-    </None>
-    <None Update="appsettings.Development.json">
+    <None Update="appsettings*.json">
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
     </None>
   </ItemGroup>

Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,7 @@ public AIChatService(IOptions<AIOptions> options, AISearchService searchService)`
`105`	`105`	`/// </summary>`
`106`	`106`	`private async Task<string> EnrichPromptWithContext(string prompt, bool enableContextualSearch, CancellationToken cancellationToken)`
`107`	`107`	`{`
`108`		`- if (!enableContextualSearch \|\| _SearchService == null)`
	`108`	`+ if (!enableContextualSearch)`
`109`	`109`	`{`
`110`	`110`	`return prompt;`
`111`	`111`	`}`
Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,6 @@ public class FileChunkingResult`
`9`	`9`	`public string FilePath { get; set; } = string.Empty;`
`10`	`10`	`public int OriginalCharCount { get; set; }`
`11`	`11`	`public int ChunkCount { get; set; }`
`12`		`- public List<string> Chunks { get; set; } = new();`
	`12`	`+ public List<string> Chunks { get; set; } = [];`
`13`	`13`	`public int TotalChunkCharacters { get; set; }`
`14`	`14`	`}`