test: address PR feedback on startup order and redirects

Author: BenjaminMichaelis

EssentialCSharp.Web.Tests/FunctionalTests.cs

@@ -13,7 +13,7 @@ public class FunctionalTests : IntegrationTestBase
     [Arguments("/alive")]
     public async Task WhenTheApplicationStarts_ItCanLoadLoadPages(string relativeUrl)
     {
-        using HttpResponseMessage response = await GetWithRedirectsAsync(relativeUrl);
+        using HttpResponseMessage response = await GetFollowingRedirectsAsync(relativeUrl);
 
         await Assert.That(response.StatusCode).IsEqualTo(HttpStatusCode.OK);
     }
@@ -28,7 +28,7 @@ public async Task WhenTheApplicationStarts_ItCanLoadLoadPages(string relativeUrl
     [Arguments("/about?someOtherParam=value")]
     public async Task WhenPagesAreAccessed_TheyReturnHtml(string relativeUrl)
     {
-        using HttpResponseMessage response = await GetWithRedirectsAsync(relativeUrl);
+        using HttpResponseMessage response = await GetFollowingRedirectsAsync(relativeUrl);
 
         await Assert.That(response.StatusCode).IsEqualTo(HttpStatusCode.OK);
 
@@ -43,7 +43,7 @@ public async Task WhenPagesAreAccessed_TheyReturnHtml(string relativeUrl)
     [Test]
     public async Task WhenTheApplicationStarts_NonExistingPage_GivesCorrectStatusCode()
     {
-        using HttpResponseMessage response = await GetWithRedirectsAsync("/non-existing-page1234");
+        using HttpResponseMessage response = await GetFollowingRedirectsAsync("/non-existing-page1234");
 
         await Assert.That(response.StatusCode).IsEqualTo(HttpStatusCode.NotFound);
     }

EssentialCSharp.Web.Tests/IntegrationTestBase.cs

@@ -9,8 +9,9 @@ public abstract class IntegrationTestBase : WebApplicationTest<WebApplicationFac
     /// <summary>
     /// Executes a GET request and follows redirect responses while preserving
     /// TUnit trace correlation by using <see cref="TracedWebApplicationFactory{T}.CreateClient()"/>.
+    /// This helper intentionally follows redirects using GET requests only.
     /// </summary>
-    protected async Task<HttpResponseMessage> GetWithRedirectsAsync(string relativeUrl, int maxRedirects = 10)
+    protected async Task<HttpResponseMessage> GetFollowingRedirectsAsync(string relativeUrl, int maxRedirects = 10)
     {
         HttpClient client = Factory.CreateClient();
         HttpResponseMessage response = await client.GetAsync(relativeUrl);
@@ -30,6 +31,12 @@ protected async Task<HttpResponseMessage> GetWithRedirectsAsync(string relativeU
             response = await client.GetAsync(location);
         }
 
+        if (IsRedirectStatusCode(response.StatusCode))
+        {
+            throw new InvalidOperationException(
+                $"Exceeded redirect limit ({maxRedirects}) for '{relativeUrl}'. Last status: {(int)response.StatusCode} {response.StatusCode}.");
+        }
+
         return response;
     }
 

EssentialCSharp.Web.Tests/WebApplicationFactory.cs

@@ -56,7 +56,8 @@ protected override void ConfigureWebHost(IWebHostBuilder builder)
                 options.UseSqlite(dbConnection);
             });
 
-            services.AddHostedService<EnsureCreatedHostedService>();
+            // Ensure schema exists before any other hosted service that reads from the database.
+            services.Insert(0, ServiceDescriptor.Singleton<IHostedService, EnsureCreatedHostedService>());
 
             // Replace IListingSourceCodeService with one backed by TestData
             services.RemoveAll<IListingSourceCodeService>();