Address PR review feedback: fix log messages, trailing space, indentation, unused variable

Agent-Logs-Url: https://github.com/IntelliTect/EssentialCSharp.Web/sessions/89025ed7-2a22-4675-845d-14bc7cfdf263

Co-authored-by: BenjaminMichaelis <22186029+BenjaminMichaelis@users.noreply.github.com>

Author: Copilot

EssentialCSharp.Chat.Shared/Services/MarkdownChunkingService.cs

@@ -178,6 +178,6 @@ public FileChunkingResult ProcessSingleMarkdownFile(
     [GeneratedRegex(@"^(#{1,6}) +(.+)$")]
     private static partial Regex HeadingRegex();
 
-    [LoggerMessage(Level = LogLevel.Error, Message = "Directory {directoryName} does not exist.")]
+    [LoggerMessage(Level = LogLevel.Error, Message = "Directory {DirectoryName} does not exist.")]
     private static partial void LogDirectoryDoesNotExist(ILogger<MarkdownChunkingService> logger, string directoryName);
 }

EssentialCSharp.Web/Areas/Identity/Pages/Account/LoginWithRecoveryCode.cshtml.cs

@@ -7,7 +7,6 @@ namespace EssentialCSharp.Web.Areas.Identity.Pages.Account;
 
 public partial class LoginWithRecoveryCodeModel(
     SignInManager<EssentialCSharpWebUser> signInManager,
-    UserManager<EssentialCSharpWebUser> userManager,
     ILogger<LoginWithRecoveryCodeModel> logger) : PageModel
 {
     private InputModel? _Input;
@@ -55,8 +54,6 @@ public async Task<IActionResult> OnPostAsync(string? returnUrl = null)
 
         Microsoft.AspNetCore.Identity.SignInResult result = await signInManager.TwoFactorRecoveryCodeSignInAsync(recoveryCode);
 
-        string userId = await userManager.GetUserIdAsync(user);
-
         if (result.Succeeded)
         {
             LogUserLoggedInWithRecoveryCode(logger, user.Id);
@@ -81,6 +78,6 @@ public async Task<IActionResult> OnPostAsync(string? returnUrl = null)
     [LoggerMessage(Level = LogLevel.Warning, Message = "User account locked out.")]
     private static partial void LogUserAccountLockedOutRecovery(ILogger<LoginWithRecoveryCodeModel> logger);
 
-    [LoggerMessage(Level = LogLevel.Warning, Message = "Invalid recovery code entered for user with ID '{UserId}' ")]
+    [LoggerMessage(Level = LogLevel.Warning, Message = "Invalid recovery code entered for user with ID '{UserId}'.")]
     private static partial void LogInvalidRecoveryCode(ILogger<LoginWithRecoveryCodeModel> logger, string userId);
 }

EssentialCSharp.Web/Areas/Identity/Pages/Account/Logout.cshtml.cs

@@ -11,9 +11,9 @@ public async Task<IActionResult> OnPost(string? returnUrl = null)
     {
         await signInManager.SignOutAsync();
         LogUserLoggedOut(logger);
-            // This needs to be a redirect so that the browser performs a new
-            // request and the identity for the user gets updated.
-            return returnUrl is not null ? LocalRedirect(returnUrl) : RedirectToPage();
+        // This needs to be a redirect so that the browser performs a new
+        // request and the identity for the user gets updated.
+        return returnUrl is not null ? LocalRedirect(returnUrl) : RedirectToPage();
     }
 
     [LoggerMessage(Level = LogLevel.Information, Message = "User logged out.")]

EssentialCSharp.Web/Services/EmailSender.cs

@@ -52,9 +52,9 @@ public async Task Execute(string subject, string toEmail, string message)
     [LoggerMessage(Level = LogLevel.Error, Message = "Unexpectedly no messages returned in the mailer response")]
     private static partial void LogNoMessagesReturned(ILogger logger);
 
-    [LoggerMessage(Level = LogLevel.Information, Message = "Email to queued successfully!")]
+    [LoggerMessage(Level = LogLevel.Information, Message = "Email queued successfully.")]
     private static partial void LogEmailQueued(ILogger logger);
 
-    [LoggerMessage(Level = LogLevel.Error, Message = "Failure To Send Email")]
+    [LoggerMessage(Level = LogLevel.Error, Message = "Failed to send email.")]
     private static partial void LogEmailSendFailure(ILogger logger);
 }