Skip to content

Commit cd8b751

Browse files
fix: correct buildkit cache read/write semantics per review
PR workflow: - Use actions/cache/restore (restore-only) so PR builds never write new/stale cache entries on a cache miss - Set skip-extraction: true so BuildKit mount cache is never written back on PR builds Deploy workflow: - Set skip-extraction: false so the canonical cache is always refreshed after each main-branch build - Remove unused essentialcsharpweb-deploy scope from cache-from; that scope was never written to so it added no value
1 parent 9ec9c45 commit cd8b751

2 files changed

Lines changed: 4 additions & 6 deletions

File tree

.github/workflows/Build-Test-And-Deploy.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ jobs:
7878
builder: ${{ steps.buildx.outputs.name }}
7979
dockerfile: EssentialCSharp.Web/Dockerfile
8080
cache-dir: buildkit-cache
81-
skip-extraction: ${{ steps.buildkit-cache.outputs.cache-hit }}
81+
skip-extraction: false
8282

8383
# Only build for dev registry — prod gets the image via az acr import in deploy-production
8484
- name: Build Container Image
@@ -91,9 +91,7 @@ jobs:
9191
secrets: |
9292
"nuget_pat=${{ secrets.AZURE_DEVOPS_PAT }}"
9393
outputs: type=docker,dest=${{ github.workspace }}/essentialcsharpwebimage.tar
94-
cache-from: |
95-
type=gha,scope=essentialcsharpweb-main
96-
type=gha,scope=essentialcsharpweb-deploy
94+
cache-from: type=gha,scope=essentialcsharpweb-main
9795
cache-to: type=gha,mode=max,scope=essentialcsharpweb-main
9896

9997
- name: Upload artifact

.github/workflows/PR-Build-And-Test.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ jobs:
8585
id: buildx
8686

8787
- name: Restore BuildKit cache mounts
88-
uses: actions/cache@v5
88+
uses: actions/cache/restore@v5
8989
id: buildkit-cache
9090
with:
9191
path: buildkit-cache
@@ -98,7 +98,7 @@ jobs:
9898
builder: ${{ steps.buildx.outputs.name }}
9999
dockerfile: EssentialCSharp.Web/Dockerfile
100100
cache-dir: buildkit-cache
101-
skip-extraction: ${{ steps.buildkit-cache.outputs.cache-hit }}
101+
skip-extraction: true
102102

103103
- name: Build Container Image
104104
uses: docker/build-push-action@v7

0 commit comments

Comments
 (0)