fix(tests): make WebApplicationFactory service overrides idempotent

Remove prior matching registrations for DbContext options, DbConnection, DatabaseMigrationService, and EnsureCreatedHostedService before re-adding test overrides. Also keep the SQLite keep-alive connection creation guarded with ??= across repeated ConfigureServices invocations.

This avoids duplicate EnsureCreated hosted services racing each other and failing CI with SQLite Error 1: table AspNetRoles already exists.

Author: BenjaminMichaelis

EssentialCSharp.Web.Tests/WebApplicationFactory.cs

@@ -26,38 +26,42 @@ protected override void ConfigureWebHost(IWebHostBuilder builder)
     {
         builder.ConfigureServices(services =>
         {
-            ServiceDescriptor? dbContextDescriptor = services.SingleOrDefault(
-                d => d.ServiceType ==
-                    typeof(IDbContextOptionsConfiguration<EssentialCSharpWebContext>));
-
-            if (dbContextDescriptor != null)
+            for (int i = services.Count - 1; i >= 0; i--)
             {
-                services.Remove(dbContextDescriptor);
+                if (services[i].ServiceType ==
+                    typeof(IDbContextOptionsConfiguration<EssentialCSharpWebContext>))
+                {
+                    services.RemoveAt(i);
+                }
             }
 
-            ServiceDescriptor? dbConnectionDescriptor =
-                services.SingleOrDefault(
-                    d => d.ServiceType ==
-                    typeof(DbConnection));
-
-            if (dbConnectionDescriptor != null)
+            for (int i = services.Count - 1; i >= 0; i--)
             {
-                services.Remove(dbConnectionDescriptor);
+                if (services[i].ServiceType == typeof(DbConnection))
+                {
+                    services.RemoveAt(i);
+                }
             }
 
             // Remove DatabaseMigrationService: it calls MigrateAsync which conflicts
             // with EnsureCreated() used below for the in-memory SQLite test database.
-            ServiceDescriptor? migrationServiceDescriptor = services.SingleOrDefault(
-                d => d.ImplementationType == typeof(DatabaseMigrationService));
-            if (migrationServiceDescriptor != null)
+            for (int i = services.Count - 1; i >= 0; i--)
             {
-                services.Remove(migrationServiceDescriptor);
+                ServiceDescriptor descriptor = services[i];
+                if (descriptor.ServiceType == typeof(IHostedService) &&
+                    descriptor.ImplementationType == typeof(DatabaseMigrationService))
+                {
+                    services.RemoveAt(i);
+                }
             }
 
             // Open a keep-alive connection to prevent the shared-cache in-memory database from
             // being dropped when per-scope connections are disposed between requests.
-            _keepAliveConnection = new SqliteConnection(_sqlConnectionString);
-            _keepAliveConnection.Open();
+            _keepAliveConnection ??= new SqliteConnection(_sqlConnectionString);
+            if (_keepAliveConnection.State != System.Data.ConnectionState.Open)
+            {
+                _keepAliveConnection.Open();
+            }
 
             // Register as scoped so each request scope gets its own SqliteConnection,
             // preventing "database is locked" errors under concurrent requests.
@@ -75,6 +79,16 @@ protected override void ConfigureWebHost(IWebHostBuilder builder)
             });
 
             // Ensure schema exists before any hosted service that reads from the database.
+            for (int i = services.Count - 1; i >= 0; i--)
+            {
+                ServiceDescriptor descriptor = services[i];
+                if (descriptor.ServiceType == typeof(IHostedService) &&
+                    descriptor.ImplementationType == typeof(EnsureCreatedHostedService))
+                {
+                    services.RemoveAt(i);
+                }
+            }
+
             ServiceDescriptor ensureCreatedDescriptor =
                 ServiceDescriptor.Singleton<IHostedService, EnsureCreatedHostedService>();
             int firstHostedServiceIndex = -1;