fix: remove redundant --registry flag from az acr import#1083
Merged
Conversation
When --source already contains the full registry hostname (e.g. ecsdevacr.azurecr.io/image:tag), the --registry flag is redundant and az acr import emits a WARNING that it will be ignored. Drop --registry to eliminate the noise. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes a redundant --registry flag from the az acr import call in the production deploy workflow. The --source argument already includes the full azurecr.io hostname, so --registry was producing a warning on every production deploy.
Changes:
- Drop
--registry "${DEV_ACR%.azurecr.io}"from theaz acr importinvocation in the deploy-production job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
az acr importwas being called with both--source <registry>/<image>:<tag>(which includes the full hostname) and--registry <name>, causing this warning on every prod deploy:--registryis only needed when--sourceomits the registry hostname. Since our--sourcealready contains the fullazurecr.iohostname,--registryis redundant.Fix
Drop the
--registryflag from theaz acr importcall indeploy-production.