Skip to content

Improve error-page recovery navigation to prevent dead ends #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BenjaminMichaelis merged 3 commits into from
May 14, 2026
Merged

Improve error-page recovery navigation to prevent dead ends #1103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
505086a
Initial plan
Copilot May 14, 2026
18bfd8e
fix: add error page chapter navigation action
Copilot May 14, 2026
f51f01d
fix: route error page chapter link to first chapter
Copilot May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion EssentialCSharp.Web.Tests/FunctionalTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,5 +51,10 @@ public async Task WhenTheApplicationStarts_NonExistingPage_GivesCorrectStatusCod
using HttpResponseMessage response = await client.GetAsync("/non-existing-page1234");

await Assert.That(response.StatusCode).IsEqualTo(HttpStatusCode.NotFound);

string content = await response.Content.ReadAsStringAsync();
await Assert.That(content).Contains("Go Home");
await Assert.That(content).Contains("Go Back");
await Assert.That(content).Contains("Browse Chapters");
}
}
}
1 change: 1 addition & 0 deletions EssentialCSharp.Web/Views/Home/Error.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
}
<div class="d-flex gap-2">
<a href="/home" class="btn btn-primary">Go Home</a>
<a href="/hello-world" class="btn btn-outline-primary">Browse Chapters</a>
<button type="button" class="btn btn-secondary"
onclick="if(history.length > 1){ history.back(); } else { window.location='/home'; }">
Go Back
Expand Down
Loading