Skip to content

Commit 061db6e

Browse files
createreadupdatedebuggerone
authored andcommitted
Avoid ctype dependency in websocket wire helper
1 parent 1ab8523 commit 061db6e

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

extension/tests/server_websocket_wire_helper.inc

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,11 @@
22

33
/* Test helper for starting the on-wire HTTP/1/WebSocket one-shot listener harness. */
44

5+
function king_server_websocket_wire_is_decimal_digits(string $value): bool
6+
{
7+
return $value !== '' && strspn($value, '0123456789') === strlen($value);
8+
}
9+
510
function king_server_websocket_wire_start_server(string $mode, int $iterations = 1, ?int $fixedPort = null, array $env = []): array
611
{
712
$maxAttempts = $fixedPort !== null ? 1 : 10;
@@ -32,7 +37,7 @@ function king_server_websocket_wire_start_server(string $mode, int $iterations =
3237
}
3338

3439
$portText = substr($serverName, $colon + 1);
35-
if ($portText === '' || !ctype_digit($portText)) {
40+
if (!king_server_websocket_wire_is_decimal_digits($portText)) {
3641
throw new RuntimeException('reserved on-wire HTTP/1 test port was not numeric');
3742
}
3843

0 commit comments

Comments
 (0)