Start php83 branch

Merge branch 'php81' into php83

# Conflicts:
#	composer.json

Author: jgrehling

library/Zend/Filter/LocalizedToNormalized.php

@@ -97,6 +97,8 @@ public function setOptions(?array $options = null)
      */
     public function filter($value)
     {
+        $value = $this->filterTrailingNumberSigns($value);
+
         if (Zend_Locale_Format::isNumber($value, $this->_options)) {
             return Zend_Locale_Format::getNumber($value, $this->_options);
         } else if (($this->_options['date_format'] === null) && (strpos($value, ':') !== false)) {
@@ -109,4 +111,26 @@ public function filter($value)
 
         return $value;
     }
+
+    /**
+     * Remove dots and commas from the end of the given value, as they lead to problems and are usually unintended
+     * by  the user who entered them.
+     */
+    private function filterTrailingNumberSigns($value)
+    {
+        if (empty($value)) {
+            return $value;
+        }
+
+        if (!is_string($value)) {
+            return $value;
+        }
+
+        $lastChar = substr($value, -1, 1);
+        $numberFormattingChars = [',', '.'];
+        if (!empty($value) && in_array($lastChar, $numberFormattingChars)) {
+            $value = rtrim($value, implode('', $numberFormattingChars));
+        }
+        return $value;
+    }
 }

library/Zend/Session/SaveHandler/DbTable.php

@@ -290,7 +290,7 @@ public function getOverrideLifetime()
      * @param string $name
      * @return boolean
      */
-    public function open($save_path, $name)
+    public function open(string $save_path, string $name): bool
     {
         $this->_sessionSavePath = $save_path;
         $this->_sessionName     = $name;
@@ -303,7 +303,7 @@ public function open($save_path, $name)
      *
      * @return boolean
      */
-    public function close()
+    public function close(): bool
     {
         return true;
     }
@@ -314,7 +314,7 @@ public function close()
      * @param string $id
      * @return string
      */
-    public function read($id)
+    public function read(string $id): string
     {
         $return = '';
 
@@ -338,7 +338,7 @@ public function read($id)
      * @param string $data
      * @return boolean
      */
-    public function write($id, $data)
+    public function write(string $id, string $data): bool
     {
         $data = [$this->_modifiedColumn => time(),
                       $this->_dataColumn     => (string) $data];
@@ -366,7 +366,7 @@ public function write($id, $data)
      * @param string $id
      * @return boolean
      */
-    public function destroy($id)
+    public function destroy($id): bool
     {
         $this->delete($this->_getPrimary($id, self::PRIMARY_TYPE_WHERECLAUSE));
         return true; //always return true, since if nothing can be deleted, it is already deleted and thats OK.
@@ -378,13 +378,11 @@ public function destroy($id)
      * @param int $maxlifetime
      * @return true
      */
-    public function gc($maxlifetime)
+    public function gc(int $maxlifetime): int
     {
-        $this->delete($this->getAdapter()->quoteIdentifier($this->_modifiedColumn, true) . ' + '
-                    . $this->getAdapter()->quoteIdentifier($this->_lifetimeColumn, true) . ' < '
-                    . $this->getAdapter()->quote(time()));
-
-        return true;
+        return $this->delete($this->getAdapter()->quoteIdentifier($this->_modifiedColumn, true) . ' + '
+            . $this->getAdapter()->quoteIdentifier($this->_lifetimeColumn, true) . ' < '
+            . $this->getAdapter()->quote(time()));
     }
 
     /**

php83.info.md

@@ -0,0 +1,10 @@
+PHP8.3 Intera Version
+
+Branch is based on 8.2 compabible release https://github.com/Shardj/zf1-future/releases/tag/release-1.25.0 from
+base repository.
+
+We add previous customizations that we did in php81 branch on top.
+
+Additionally, we had some composer patches that we applied in php81, that are now part of this branch as well.
+
+Lastly, we fixed some php8.3 deprecations.