perf: use String.fromCharCode.apply in floats32ToBase64 example#215
Open
rdgordon-index wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The current encode example accumulates a binary string by appending one character per byte in a
for...ofloop. Each iteration allocates a new string, making the total cost O(n) allocations for an n-byte vector.String.fromCharCode.apply(null, bytes)processes all bytes in a single native call, avoiding the per-byte re-allocations. Benchmarked with Benchmark.js against normalized unit-sphere float32 vectors across realistic embedding dimensions:for…of(ops/sec)apply(ops/sec)The spec example row was reproduced with:
Works in all modern browsers with no caveats. A comment in the code notes that very large inputs should be chunked into ~8192-byte blocks to stay within engine argument count limits, though this is not a concern for any embedding dimension currently in use.
The decode example is unchanged — there is no browser-compatible equivalent speedup for that path.