feat: remove headless execution mode — all hooks run in a terminal tab

- Remove headless subprocess execution path from hooks.rs
- Remove ALLOWED_EXECUTION_MODES, validate_execution_mode, trigger_supports_terminal_tab helpers
- Remove write_hook_script_file, read_limited_output, truncate_utf8, hook_script_extension, resolve_script_execution
- Remove SystemAction::HookExecute variant from git/helpers.rs
- Remove execution_mode from HookUpsertInput; hardcode terminal_tab in create/update handlers
- Lift before_* trigger restriction since headless is no longer an alternative
- Add DB migration 005 to update any existing headless rows to terminal_tab
- Narrow HookExecutionMode to 'terminal_tab' only in sproutgit.ts
- Remove execution mode UI from WorkspaceHooksModal.svelte
- Update E2E seeds (including raw SQL inserts) to terminal_tab
- Update website Features.astro hooks description

Author: liam-russell

e2e/specs/daily-workflow.spec.ts

@@ -97,7 +97,7 @@ type HookSeedInput = {
   script: string;
   scope?: 'worktree' | 'workspace';
   executionTarget?: 'workspace' | 'trigger_worktree' | 'initiating_worktree';
-  executionMode?: 'headless' | 'terminal_tab';
+  executionMode?: 'terminal_tab';
   enabled?: 0 | 1;
   critical?: 0 | 1;
   keepOpenOnCompletion?: 0 | 1;
@@ -119,7 +119,7 @@ function insertHookDefinition(dbPath: string, input: HookSeedInput) {
       `  ${sqlString(input.scope ?? 'workspace')},`,
       `  ${sqlString(input.trigger)},`,
       `  ${sqlString(input.executionTarget ?? 'trigger_worktree')},`,
-      `  ${sqlString(input.executionMode ?? 'headless')},`,
+      `  ${sqlString(input.executionMode ?? 'terminal_tab')},`,
       `  ${sqlString(input.shell)},`,
       `  ${sqlString(input.script)},`,
       `  ${input.enabled ?? 1},`,
@@ -558,14 +558,15 @@ test.describe('Daily developer workflow', () => {
       stateDbPath,
       [
         'INSERT INTO hook_definitions (',
-        '  id, name, scope, trigger, shell, script, enabled, critical, timeout_seconds, created_at, updated_at',
+        '  id, name, scope, trigger, shell, script, execution_mode, enabled, critical, timeout_seconds, created_at, updated_at',
         ') VALUES (',
         `  ${sqlString(hookId)},`,
         `  ${sqlString('Daily after-create hook')},`,
         `  ${sqlString('workspace')},`,
         `  ${sqlString('after_worktree_create')},`,
         `  ${sqlString(shell)},`,
         `  ${sqlString(script)},`,
+        `  ${sqlString('terminal_tab')},`,
         '  1,',
         '  0,',
         '  60,',

e2e/specs/hero-screenshots.spec.ts

@@ -1,6 +1,14 @@
+import { dirname, join } from 'node:path';
+
 import { test } from '../fixtures';
 import { createHeroMediaRepo } from '../helpers/benchmark-repos';
-import { appendRepoFile, resetConfigDb, resetTestDirs, writeRepoFile } from '../helpers/fixtures';
+import {
+  appendRepoFile,
+  executeSqlite,
+  resetConfigDb,
+  resetTestDirs,
+  writeRepoFile,
+} from '../helpers/fixtures';
 import { captureScreenshotVariants, resizeWindowForScreenshot } from '../helpers/screenshots';
 import {
   createWorktreeViaUi,
@@ -11,6 +19,42 @@ import {
   reloadToHome,
 } from '../helpers/ui';
 
+function sqlStr(value: string) {
+  return `'${value.replaceAll("'", "''")}'`;
+}
+
+function seedHook(
+  dbPath: string,
+  id: string,
+  name: string,
+  trigger: string,
+  executionMode: 'terminal_tab',
+  critical: 0 | 1 = 0
+) {
+  const now = Math.floor(Date.now() / 1000);
+  executeSqlite(
+    dbPath,
+    [
+      'INSERT INTO hook_definitions (',
+      '  id, name, scope, trigger, execution_target, execution_mode, shell, script,',
+      '  enabled, critical, keep_open_on_completion, timeout_seconds, created_at, updated_at',
+      ') VALUES (',
+      `  ${sqlStr(id)}, ${sqlStr(name)}, 'workspace', ${sqlStr(trigger)},`,
+      `  'trigger_worktree', ${sqlStr(executionMode)}, 'bash',`,
+      `  'echo "Running ${name}"',`,
+      `  1, ${critical}, 0, 60, ${now}, ${now}`,
+      ');',
+    ].join('\n')
+  );
+}
+
+function seedHookDependency(dbPath: string, hookId: string, dependsOnId: string) {
+  executeSqlite(
+    dbPath,
+    `INSERT INTO hook_dependencies (hook_id, depends_on_hook_id) VALUES (${sqlStr(hookId)}, ${sqlStr(dependsOnId)});`
+  );
+}
+
 test.describe('Hero screenshots @screenshots', () => {
   test.skip(
     !process.env.CAPTURE_SCREENSHOTS,
@@ -208,5 +252,36 @@ test.describe('Hero screenshots @screenshots', () => {
     // Give terminals time to render their output.
     await new Promise(r => setTimeout(r, 2000));
     await captureScreenshotVariants(tauriPage, testInfo, 'terminal/grid-view');
+
+    // ── Shot 6: hooks/management — workspace hooks modal with seeded hooks ────
+    // Derive stateDbPath from settingsPath: worktree → worktrees → workspace → .sproutgit/state.db
+    const stateDbPath = join(dirname(dirname(settingsPath)), '.sproutgit', 'state.db');
+
+    // Seed three representative hooks so the modal looks rich.
+    const hookSetupId = 'hero-hook-setup';
+    const hookLintId = 'hero-hook-lint';
+    const hookCleanId = 'hero-hook-clean';
+    seedHook(stateDbPath, hookSetupId, 'Set up dev environment', 'after_worktree_create', 'terminal_tab', 1);
+    seedHook(stateDbPath, hookLintId, 'Run linter & type check', 'after_worktree_create', 'terminal_tab');
+    seedHook(stateDbPath, hookCleanId, 'Clean build cache', 'before_worktree_remove', 'terminal_tab');
+    // "Run linter" depends on "Set up dev environment" so it shows indentation.
+    seedHookDependency(stateDbPath, hookLintId, hookSetupId);
+
+    // Open the hooks modal via the workspace settings button.
+    await tauriPage.getByTestId('btn-workspace-settings').click();
+    await tauriPage.getByTestId('hooks-modal').waitFor(DEFAULT_UI_TIMEOUT);
+
+    // Wait until hook rows are rendered (hooks loaded from DB).
+    await tauriPage.waitForFunction(
+      `(() => document.querySelectorAll('[data-testid="hook-list-row"]').length >= 3)()`,
+      DEFAULT_UI_TIMEOUT
+    );
+    // Let entrance animations finish.
+    await new Promise(r => setTimeout(r, 400));
+
+    await captureScreenshotVariants(tauriPage, testInfo, 'hooks/management');
+
+    // Close the modal before the test ends.
+    await tauriPage.evaluate(`document.body.click()`);
   });
 });