Skip to content

Restore fogColor during load#2731

Open
Z-Machine wants to merge 1 commit into
Interkarma:masterfrom
Z-Machine:FogFix
Open

Restore fogColor during load#2731
Z-Machine wants to merge 1 commit into
Interkarma:masterfrom
Z-Machine:FogFix

Conversation

@Z-Machine

Copy link
Copy Markdown

Fixes the issue described in #2730

@KABoissonneault

Copy link
Copy Markdown
Collaborator

Thank you for looking into issues. Should be good to go once I get around to testing this

@Johuotar

Johuotar commented Apr 4, 2025

Copy link
Copy Markdown

For what its worth, I tested the master for this bug (fog turning black), and could reproduce it with 100% certainty by entering a house in foggy weather, saving, then loading the save and exiting. With this branch the bug did not occur despite several tests. Then I did general play for 90 minutes and no problems occurred. I did testing with Win10, in the Unity editor, if that matters.
If there's something else I could test just say so, perhaps this branch with mods?

@KABoissonneault

Copy link
Copy Markdown
Collaborator

Thank you for testing. This is small enough that I'm not too worried about mod compatibility, I'll just do a basic code review next week

@Daneel53 Daneel53 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgotten bug fix.
Time to put this into DFU.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants