Merged
Conversation
jinminxi104
requested changes
Apr 2, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates DLInfer paged-attention plumbing to fix prefix caching behavior (notably for Ascend), primarily by renaming the “unpaged prefill” flag to a clearer “prefill w/o cache” concept and by passing q_seqlens into the token-attention kernel path.
Changes:
- Rename
is_unpaged_prefill→is_prefill_no_cacheacross DLInfer attention metadata and backends. - Pass
q_seqlensthrough the paged token-attention wrapper into the underlying ext op. - Adjust Ascend backend sequence-length/mask preparation logic used for prefix/paged prefill.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| lmdeploy/pytorch/kernels/dlinfer/pagedattention.py | Renames prefill flag and threads q_seqlens into token-attention execution. |
| lmdeploy/pytorch/backends/dlinfer/maca/op_backend.py | Updates metadata flag name for prefill/caching behavior. |
| lmdeploy/pytorch/backends/dlinfer/camb/op_backend.py | Updates metadata flag name and related conditional logic. |
| lmdeploy/pytorch/backends/dlinfer/attention.py | Renames metadata field and forwards it into the kernel call. |
| lmdeploy/pytorch/backends/dlinfer/ascend/op_backend.py | Reworks Ascend prefill/prefix-caching preparation (seqlens + attention mask), and updates flag naming. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jinminxi104
approved these changes
Apr 7, 2026
grimoire
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.