Skip to content

Add usage.prompt_tokens_details.cached_tokens for prefix caching#4670

Open
lvhan028 wants to merge 5 commits into
InternLM:mainfrom
lvhan028:feat/cached-tokens-usage
Open

Add usage.prompt_tokens_details.cached_tokens for prefix caching#4670
lvhan028 wants to merge 5 commits into
InternLM:mainfrom
lvhan028:feat/cached-tokens-usage

Conversation

@lvhan028

@lvhan028 lvhan028 commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Motivation

OpenAI reports prefix cache hits in usage.prompt_tokens_details.cached_tokens, which clients use for cost estimation and observability (cache_hit_rate = cached_tokens / prompt_tokens).

LMDeploy's supports prefix caching, but this hit count was not surfaced through the serving API. Without it, users cannot measure prefix cache effectiveness from chat completion responses or benchmark results.

Modification

PyTorch engine

  • Record prefix cache hits in BlockTrie.match() as SchedulerSequence.cached_tokens.
  • Propagate the value through RequestMetricsGenOut / Response → OpenAI usage.
  • Fix a scheduler bug in the migration path: block_trie.match(migration_waiting)block_trie.match(seq).

Turbomind engine

TBD. After @lzhangzz refactor prefix caching

OpenAI API (/v1/chat/completions)

  • Add PromptTokensDetails and UsageInfo.build() to always populate usage.prompt_tokens_details.cached_tokens (0 when prefix caching is disabled).
  • Wire cached token counts into both streaming (stream_options.include_usage) and non-streaming responses.
  • Not added to /v1/completions (deprecated by OpenAI).

Other endpoints(v1/messages, v1/response)

TBD

Metrics

  • Add Prometheus metrics:
    • lmdeploy:request_cached_tokens
    • lmdeploy:request_cache_hit_ratio
    • lmdeploy:cached_tokens_total

Benchmark

  • Parse cached_tokens from usage in benchmark/benchmark_chat_completion.py.
  • Add per-request cached_tokens and aggregate total_cached_tokens / cache_hit_rate to summary output.
  • Forward optional tools / tool_choice fields from JSONL inputs.

Copilot AI review requested due to automatic review settings June 10, 2026 13:56
@lvhan028 lvhan028 marked this pull request as draft June 10, 2026 13:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds end-to-end reporting for prefix-cache hit tokens (“cached tokens”) so that OpenAI-compatible responses can expose usage.prompt_tokens_details.cached_tokens, and internal metrics/benchmarks can track prefix caching effectiveness.

Changes:

  • Add PromptTokensDetails(cached_tokens) to the OpenAI protocol and centralize usage construction via build_usage_info(...).
  • Plumb cached_tokens from prefix-cache matching (BlockTrie.match) through PyTorch engine messaging/metrics to server responses (GenOut.cached_tokens).
  • Add Prometheus metrics + benchmark support for cached token counts / cache hit ratio, and add unit tests for the new behavior.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
File Description
lmdeploy/serve/openai/protocol.py Adds PromptTokensDetails and build_usage_info to include cached token details in UsageInfo.
lmdeploy/serve/openai/api_server.py Switches usage construction to build_usage_info and forwards res.cached_tokens into OpenAI responses.
lmdeploy/serve/core/async_engine.py Adds cached_tokens to GenOut and propagates it from engine outputs into responses.
lmdeploy/pytorch/paging/scheduler.py Fixes migration scheduling to call block_trie.match(seq) correctly.
lmdeploy/pytorch/paging/block_trie.py Records seq.prefix_cache_hit_tokens (and resets to 0 when prefix caching is disabled).
lmdeploy/pytorch/messages.py Adds prefix_cache_hit_tokens to SchedulerSequence for prefix caching accounting.
lmdeploy/pytorch/engine/engine_loop.py Emits cached_tokens in RequestMetrics based on msg.prefix_cache_hit_tokens.
lmdeploy/pytorch/engine/engine_instance.py Extracts cached_tokens from req_metrics and forwards it via EngineOutput.
lmdeploy/messages.py Adds cached_tokens fields to Response, RequestMetrics, and EngineOutput dataclasses.
lmdeploy/metrics/stats.py Adds cached_tokens to per-request stats.
lmdeploy/metrics/metrics_processor.py Copies outputs.cached_tokens into RequestStats.cached_tokens.
lmdeploy/metrics/loggers.py Adds Prometheus histograms/counter for cached tokens and cache-hit ratio.
benchmark/benchmark_chat_completion.py Forwards per-row tools/tool_choice and extracts cached_tokens from streamed usage payloads for reporting.
tests/test_lmdeploy/test_prefix_cache_hit_tokens.py Adds a unit test ensuring disabled prefix caching sets hit tokens to 0.
tests/test_lmdeploy/serve/openai/test_usage_info.py Adds unit tests verifying prompt_tokens_details.cached_tokens appears in built usage and dumps correctly.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lvhan028 lvhan028 force-pushed the feat/cached-tokens-usage branch from ebe59b2 to 1d09d06 Compare June 12, 2026 06:56
@lvhan028 lvhan028 marked this pull request as ready for review June 12, 2026 07:32
@lvhan028 lvhan028 requested review from CUHKSZzxy and grimoire June 12, 2026 07:32
@lvhan028 lvhan028 requested a review from Copilot June 12, 2026 07:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Comment on lines +354 to +357
req_metrics = RequestMetrics(new_token_timestamp,
msg.engine_events,
spec_info=spec_info,
cached_tokens=msg.cached_tokens)
@lvhan028 lvhan028 force-pushed the feat/cached-tokens-usage branch from bfaaee5 to c227302 Compare June 16, 2026 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants