Track consumed samples in DataLoader; skip per-step total-token reduction#1652
Merged
jayhenry merged 14 commits intoInternLM:mainfrom Apr 7, 2026
Merged
Track consumed samples in DataLoader; skip per-step total-token reduction#1652jayhenry merged 14 commits intoInternLM:mainfrom
jayhenry merged 14 commits intoInternLM:mainfrom
Conversation
jayhenry
changed the title
HAOCHENYE
approved these changes
Apr 3, 2026
… data-parallel groups
jayhenry
force-pushed
the
skip_reduce_tokens
branch
from
f049f4b to
9a81d9c
Compare
jayhenry
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors how total consumed samples are tracked and resumed:
DataLoader(with updated save/restore paths); remove the older resume helpers fromresume.py.dp_meshonly, matching DP-local semantics.