Fix PlutusV4 script handling and scrambled ToPlutusScriptPurpose type family

Author: carbolymer

cardano-api/src/Cardano/Api/Experimental/Plutus/Internal/Shim/LegacyScripts.hs

@@ -75,11 +75,11 @@ toAnyWitness eon (witnessable, BuildTxWith (Old.ScriptWitness _ oldApiPlutusScri
 
 type family ToPlutusScriptPurpose witnessable = (purpose :: PlutusScriptPurpose) | purpose -> witnessable where
   ToPlutusScriptPurpose TxInItem = SpendingScript
-  ToPlutusScriptPurpose CertItem = MintingScript
-  ToPlutusScriptPurpose MintItem = CertifyingScript
+  ToPlutusScriptPurpose CertItem = CertifyingScript
+  ToPlutusScriptPurpose MintItem = MintingScript
   ToPlutusScriptPurpose WithdrawalItem = WithdrawingScript
-  ToPlutusScriptPurpose VoterItem = ProposingScript
-  ToPlutusScriptPurpose ProposalItem = VotingScript
+  ToPlutusScriptPurpose VoterItem = VotingScript
+  ToPlutusScriptPurpose ProposalItem = ProposingScript
 
 convertToNewScriptWitness
   :: AlonzoEraOnwards era

cardano-api/src/Cardano/Api/Experimental/Tx/Internal/AnyWitness.hs

@@ -125,7 +125,7 @@ getPlutusDatum
 getPlutusDatum L.SPlutusV1 (SpendingScriptDatum d) = Just d
 getPlutusDatum L.SPlutusV2 (SpendingScriptDatum d) = Just d
 getPlutusDatum L.SPlutusV3 (SpendingScriptDatum d) = d
-getPlutusDatum L.SPlutusV4 (SpendingScriptDatum _d) = error "TODO Dijkstra: getPlutusDatum: era not supported"
+getPlutusDatum L.SPlutusV4 (SpendingScriptDatum d) = d
 getPlutusDatum _ InlineDatum = Nothing
 getPlutusDatum _ NoScriptDatum = Nothing
 

cardano-api/src/Cardano/Api/Plutus/Internal/Script.hs

@@ -385,7 +385,7 @@ fromAlonzoLanguage :: Plutus.Language -> AnyPlutusScriptVersion
 fromAlonzoLanguage Plutus.PlutusV1 = AnyPlutusScriptVersion PlutusScriptV1
 fromAlonzoLanguage Plutus.PlutusV2 = AnyPlutusScriptVersion PlutusScriptV2
 fromAlonzoLanguage Plutus.PlutusV3 = AnyPlutusScriptVersion PlutusScriptV3
-fromAlonzoLanguage Plutus.PlutusV4 = AnyPlutusScriptVersion PlutusScriptV3
+fromAlonzoLanguage Plutus.PlutusV4 = AnyPlutusScriptVersion PlutusScriptV4
 
 class HasTypeProxy lang => IsScriptLanguage lang where
   scriptLanguage :: ScriptLanguage lang
@@ -1294,20 +1294,16 @@ toShelleyScript
           Plutus.PlutusBinary script
 toShelleyScript
   ( ScriptInEra
-      _langInEra
+      langInEra
       ( PlutusScript
           PlutusScriptV4
-          (PlutusScriptSerialised _script)
+          (PlutusScriptSerialised script)
         )
-    ) = error "toShelleyScript: PlutusV4 not implemented yet."
-
--- TODO: Ledger needs to introduce a plutusV4 constructor
--- case langInEra of
---   PlutusScriptV4InConway ->
---     Alonzo.PlutusScript . Conway.ConwayPlutusV3 . Plutus.Plutus $ Plutus.PlutusBinary script
---   PlutusScriptV4InDijkstra ->
---     Alonzo.PlutusScript . Dijkstra.MkDijkstraPlutusScript . Conway.ConwayPlutusV3 . Plutus.Plutus $
---       Plutus.PlutusBinary script
+    ) =
+    case langInEra of
+      PlutusScriptV4InDijkstra ->
+        Alonzo.PlutusScript . Dijkstra.DijkstraPlutusV4 . Plutus.Plutus $
+          Plutus.PlutusBinary script
 
 fromShelleyBasedScript
   :: ShelleyBasedEra era
@@ -1391,8 +1387,8 @@ fromShelleyBasedScript sbe script =
                 $ PlutusScriptSerialised s
             Dijkstra.DijkstraPlutusV4 (PlutusScriptBinary s) ->
               ScriptInEra
-                PlutusScriptV3InDijkstra
-                . PlutusScript PlutusScriptV3
+                PlutusScriptV4InDijkstra
+                . PlutusScript PlutusScriptV4
                 $ PlutusScriptSerialised s
         Alonzo.NativeScript s ->
           ScriptInEra SimpleScriptInDijkstra