Fix shellcheck warnings in fix-haddock-links.sh

Replace sed call with bash regex parameter expansion (SC2001) and
annotate the xargs sh -c command with a shellcheck disable directive
for SC2016 (the single quotes are intentional — the expansions must
be evaluated by the inner sh -c, not the outer shell).

Author: Jimbo4350

scripts/fix-haddock-links.sh

@@ -147,8 +147,12 @@ while IFS= read -r target; do
   # Already exists?
   [[ -e "$WEBSITE_DIR/$target" ]] && continue
   # Strip version+hash: "base-4.20.2.0-f074" -> "base"
-  # Pattern: strip everything from the first "-DIGIT" onward
-  short_name=$(echo "$target" | sed 's/-[0-9][0-9]*\..*//')
+  # Pattern: strip everything from the first "-DIGIT.DIGIT" onward
+  if [[ "$target" =~ ^(.+)-[0-9]+\.[0-9] ]]; then
+    short_name="${BASH_REMATCH[1]}"
+  else
+    short_name="$target"
+  fi
   if [[ -v "SHORT_DIRS[$short_name]" ]]; then
     ln -s "$short_name" "$WEBSITE_DIR/$target"
     symlink_count=$((symlink_count + 1))
@@ -301,6 +305,7 @@ DEAD_URLS_FILE=$(mktemp)
 trap 'rm -f "$CHAP_PKGS_FILE" "$URLS_FILE" "$DEAD_URLS_FILE"' EXIT
 
 if [[ $url_count -gt 0 ]]; then
+  # shellcheck disable=SC2016 # single quotes intentional: expansions evaluated by inner sh -c
   xargs -P 16 -I{} sh -c \
     'code=$(curl -sI -o /dev/null -w "%{http_code}" --connect-timeout 5 --max-time 10 "{}"); if [ "$code" != "200" ] && [ "$code" != "301" ] && [ "$code" != "302" ]; then echo "{}"; fi' \
     < "$URLS_FILE" > "$DEAD_URLS_FILE" 2>/dev/null