Remove HasCallStack from Dijkstra-era placeholders, fix error messages

Dijkstra-era error placeholders don't need HasCallStack since the error
messages already identify the function. Fix error messages that were
missing the function name (fromShelleyMultiSig, fromAllegraTimelock,
getPlutusDatum, getAnchorDataFromCertificate).

Author: Jimbo4350

cardano-api/src/Cardano/Api/Certificate/Internal.hs

@@ -109,7 +109,6 @@ import Data.Text qualified as Text
 import Data.Text.Encoding qualified as Text
 import Data.Typeable
 import GHC.Exts (IsList (..), fromString)
-import GHC.Stack (HasCallStack)
 import Network.Socket (PortNumber)
 
 -- ----------------------------------------------------------------------------
@@ -813,8 +812,7 @@ instance Error AnchorDataFromCertificateError where
 -- | Get anchor data url and hash from a certificate. A return value of `Nothing`
 -- means that the certificate does not contain anchor data.
 getAnchorDataFromCertificate
-  :: HasCallStack
-  => Certificate era
+  :: Certificate era
   -> Either AnchorDataFromCertificateError (Maybe Ledger.Anchor)
 getAnchorDataFromCertificate c =
   case c of
@@ -828,7 +826,7 @@ getAnchorDataFromCertificate c =
           Ledger.RetirePoolTxCert _ _ -> return Nothing
           Ledger.GenesisDelegTxCert{} -> return Nothing
           Ledger.MirTxCert _ -> return Nothing
-          _ -> error "dijkstra"
+          _ -> error "getAnchorDataFromCertificate: Dijkstra era not supported"
     ConwayCertificate ceo ccert ->
       conwayEraOnwardsConstraints ceo $
         case ccert of
@@ -845,7 +843,7 @@ getAnchorDataFromCertificate c =
           Ledger.UpdateDRepTxCert _ mAnchor -> return $ Ledger.strictMaybeToMaybe mAnchor
           Ledger.AuthCommitteeHotKeyTxCert _ _ -> return Nothing
           Ledger.ResignCommitteeColdTxCert _ mAnchor -> return $ Ledger.strictMaybeToMaybe mAnchor
-          _ -> error "dijkstra"
+          _ -> error "getAnchorDataFromCertificate: Dijkstra era not supported"
  where
   anchorDataFromPoolMetadata
     :: MonadError AnchorDataFromCertificateError m

cardano-api/src/Cardano/Api/Experimental/Tx/Internal/AnyWitness.hs

@@ -31,7 +31,6 @@ import Cardano.Api.Tx.Internal.TxIn
 import Cardano.Ledger.Core qualified as L
 
 import Data.Type.Equality
-import GHC.Stack (HasCallStack)
 
 -- | Here we consider three types of witnesses in Cardano:
 -- * key witnesses
@@ -122,11 +121,11 @@ getAnyWitnessScript ss@(AnySimpleScriptWitness{}) = getAnyWitnessSimpleScript ss
 getAnyWitnessScript ps@(AnyPlutusScriptWitness{}) = getAnyWitnessPlutusScript ps
 
 getPlutusDatum
-  :: HasCallStack => L.SLanguage lang -> PlutusScriptDatum lang purpose -> Maybe HashableScriptData
+  :: L.SLanguage lang -> PlutusScriptDatum lang purpose -> Maybe HashableScriptData
 getPlutusDatum L.SPlutusV1 (SpendingScriptDatum d) = Just d
 getPlutusDatum L.SPlutusV2 (SpendingScriptDatum d) = Just d
 getPlutusDatum L.SPlutusV3 (SpendingScriptDatum d) = d
-getPlutusDatum L.SPlutusV4 (SpendingScriptDatum _d) = error "dijkstra"
+getPlutusDatum L.SPlutusV4 (SpendingScriptDatum _d) = error "getPlutusDatum: Dijkstra era not supported"
 getPlutusDatum _ InlineDatum = Nothing
 getPlutusDatum _ NoScriptDatum = Nothing
 

cardano-api/src/Cardano/Api/Experimental/Tx/Internal/BodyContent/New.hs

@@ -143,13 +143,11 @@ import Data.Sequence.Strict qualified as Seq
 import Data.Set (Set)
 import Data.Set qualified as Set
 import GHC.Exts (IsList (..))
-import GHC.Stack (HasCallStack)
 import Lens.Micro
 
 makeUnsignedTx
   :: forall era
-   . HasCallStack
-  => Era era
+   . Era era
   -> TxBodyContent (LedgerEra era)
   -> UnsignedTx (LedgerEra era)
 makeUnsignedTx DijkstraEra _ = error "makeUnsignedTx: Dijkstra era not supported yet"
@@ -675,8 +673,7 @@ extractWitnessableWithdrawals txWithDrawals =
 
 extractWitnessableVotes
   :: forall era
-   . HasCallStack
-  => IsEra era
+   . IsEra era
   => Maybe (TxVotingProcedures (LedgerEra era))
   -> [(Witnessable VoterItem (LedgerEra era), AnyWitness (LedgerEra era))]
 extractWitnessableVotes Nothing = []

cardano-api/src/Cardano/Api/Experimental/Tx/Internal/Certificate.hs

@@ -59,7 +59,6 @@ import Data.Array.Byte (ByteArray)
 import Data.ByteString.Short qualified as SBS
 import Data.MemPack.Buffer (byteArrayToShortByteString)
 import Data.String (IsString (fromString))
-import GHC.Stack (HasCallStack)
 
 makeStakeAddressDelegationCertificate
   :: forall era
@@ -191,8 +190,7 @@ makeStakeAddressAndDRepDelegationCertificate cred delegatee deposit =
 -- -------------------------------------
 
 getAnchorDataFromCertificate
-  :: HasCallStack
-  => Era era
+  :: Era era
   -> Certificate (LedgerEra era)
   -> Either AnchorDataFromCertificateError (Maybe Ledger.Anchor)
 getAnchorDataFromCertificate ConwayEra (Certificate c) =

cardano-api/src/Cardano/Api/Experimental/Tx/Internal/Certificate/Compatible.hs

@@ -46,8 +46,6 @@ import Cardano.Api.Plutus.Internal.Script
 
 import Cardano.Ledger.Keys qualified as Ledger
 
-import GHC.Stack (HasCallStack)
-
 type family Delegatee era where
   Delegatee DijkstraEra = Ledger.Delegatee
   Delegatee ConwayEra = Ledger.Delegatee
@@ -59,8 +57,7 @@ type family Delegatee era where
 
 makeStakeAddressDelegationCertificate
   :: forall era
-   . HasCallStack
-  => IsShelleyBasedEra era
+   . IsShelleyBasedEra era
   => StakeCredential
   -> Delegatee era
   -> Certificate (ShelleyLedgerEra era)

cardano-api/src/Cardano/Api/Plutus/Internal/Script.hs

@@ -175,7 +175,6 @@ import Data.Type.Equality (TestEquality (..), (:~:) (Refl))
 import Data.Vector (Vector)
 import Formatting qualified as B
 import GHC.Exts (IsList (..))
-import GHC.Stack (HasCallStack)
 import Numeric.Natural (Natural)
 import Prettyprinter
 
@@ -1235,7 +1234,7 @@ scriptArityForWitCtx WitCtxStake = 2
 -- Conversion functions
 --
 
-toShelleyScript :: HasCallStack => ScriptInEra era -> Ledger.Script (ShelleyLedgerEra era)
+toShelleyScript :: ScriptInEra era -> Ledger.Script (ShelleyLedgerEra era)
 toShelleyScript (ScriptInEra langInEra (SimpleScript script)) =
   case langInEra of
     SimpleScriptInShelley -> either (error . show) id (toShelleyMultiSig script)
@@ -1418,7 +1417,7 @@ toShelleyMultiSig = go
 
 -- | Conversion for the 'Shelley.MultiSig' language used by the Shelley era.
 fromShelleyMultiSig
-  :: HasCallStack => Shelley.MultiSig (ShelleyLedgerEra ShelleyEra) -> SimpleScript
+  :: Shelley.MultiSig (ShelleyLedgerEra ShelleyEra) -> SimpleScript
 fromShelleyMultiSig = go
  where
   go (Shelley.RequireSignature kh) =
@@ -1427,7 +1426,7 @@ fromShelleyMultiSig = go
   go (Shelley.RequireAllOf s) = RequireAllOf (map go $ toList s)
   go (Shelley.RequireAnyOf s) = RequireAnyOf (map go $ toList s)
   go (Shelley.RequireMOf m s) = RequireMOf m (map go $ toList s)
-  go _ = error ""
+  go _ = error "fromShelleyMultiSig: Dijkstra era not supported"
 
 -- | Conversion for the 'Timelock.Timelock' language that is shared between the
 -- Allegra and Mary eras.
@@ -1451,8 +1450,7 @@ toAllegraTimelock = go
 -- | Conversion for the 'Timelock.Timelock' language that is shared between the
 -- Allegra and Mary eras.
 fromAllegraTimelock
-  :: HasCallStack
-  => Allegra.AllegraEraScript era
+  :: Allegra.AllegraEraScript era
   => Ledger.NativeScript era -> SimpleScript
 fromAllegraTimelock = go
  where
@@ -1462,7 +1460,7 @@ fromAllegraTimelock = go
   go (Shelley.RequireAllOf s) = RequireAllOf (map go (toList s))
   go (Shelley.RequireAnyOf s) = RequireAnyOf (map go (toList s))
   go (Shelley.RequireMOf i s) = RequireMOf i (map go (toList s))
-  go _ = error "dijkstra"
+  go _ = error "fromAllegraTimelock: Dijkstra era not supported"
 
 type family ToLedgerPlutusLanguage lang where
   ToLedgerPlutusLanguage PlutusScriptV1 = Plutus.PlutusV1

cardano-api/src/Cardano/Api/Tx/Internal/Body.hs

@@ -2103,7 +2103,7 @@ mkCommonTxBody sbe txIns txOuts txFee txWithdrawals txAuxData =
   #-}
 makeShelleyTransactionBody
   :: forall era
-   . HasCallStack
+   . ()
   => ShelleyBasedEra era
   -> TxBodyContent BuildTx era
   -> Either TxBodyError (TxBody era)
@@ -3099,8 +3099,7 @@ extractWitnessableMints aeon txMintValue =
   getMints (TxMintValue _ txms) = toList txms
 
 extractWitnessableVotes
-  :: HasCallStack
-  => ConwayEraOnwards era
+  :: ConwayEraOnwards era
   -> Maybe (Featured eon era (TxVotingProcedures BuildTx era))
   -> [(Witnessable VoterItem (ShelleyLedgerEra era), BuildTxWith BuildTx (Witness WitCtxStake era))]
 extractWitnessableVotes ConwayEraOnwardsDijkstra _ = error "extractWitnessableVotes: Dijkstra era not supported"

cardano-api/src/Cardano/Api/Tx/Internal/Body/Lens.hs

@@ -68,7 +68,6 @@ import Cardano.Ledger.TxIn qualified as L
 import Data.OSet.Strict qualified as L
 import Data.Sequence.Strict qualified as L
 import Data.Set (Set)
-import GHC.Stack (HasCallStack)
 import Lens.Micro
 
 newtype LedgerTxBody era = LedgerTxBody
@@ -166,7 +165,7 @@ collateralInputsTxBodyL
 collateralInputsTxBodyL w = alonzoEraOnwardsConstraints w $ txBodyL . L.collateralInputsTxBodyL
 
 reqSignerHashesTxBodyL
-  :: HasCallStack => AlonzoEraOnwards era -> Lens' (LedgerTxBody era) (Set (L.KeyHash L.Guard))
+  :: AlonzoEraOnwards era -> Lens' (LedgerTxBody era) (Set (L.KeyHash L.Guard))
 reqSignerHashesTxBodyL w@AlonzoEraOnwardsAlonzo = alonzoEraOnwardsConstraints w $ txBodyL . L.reqSignerHashesTxBodyL
 reqSignerHashesTxBodyL w@AlonzoEraOnwardsBabbage = alonzoEraOnwardsConstraints w $ txBodyL . L.reqSignerHashesTxBodyL
 reqSignerHashesTxBodyL w@AlonzoEraOnwardsConway = alonzoEraOnwardsConstraints w $ txBodyL . L.reqSignerHashesTxBodyL