Address review: update haddock example, use failEither and liftMaybe

Author: Jimbo4350

cardano-api/src/Cardano/Api/Experimental/Tx.hs

@@ -78,7 +78,9 @@ module Cardano.Api.Experimental.Tx
     -- 'TxBodyContent' that we defined earlier:
     --
     -- @
-    -- let (Right unsignedTx) = Exp.makeUnsignedTx era txBodyContent
+    -- case Exp.makeUnsignedTx era txBodyContent of
+    --   Left err -> error (show err)
+    --   Right unsignedTx -> ...
     -- @
     --
     -- Next, use the key witness to sign the unsigned transaction with the 'makeKeyWitness' function:

cardano-api/src/Cardano/Api/Experimental/Tx/Internal/BodyContent/New.hs

@@ -105,6 +105,7 @@ import Cardano.Api.Governance.Internal.Action.VotingProcedure
 import Cardano.Api.Key.Internal
 import Cardano.Api.Ledger.Internal.Reexport (StrictMaybe (..))
 import Cardano.Api.Ledger.Internal.Reexport qualified as L
+import Cardano.Api.Monad.Error (liftMaybe)
 import Cardano.Api.Plutus.Internal.ScriptData qualified as Api
 import Cardano.Api.Pretty
 import Cardano.Api.Tx.Internal.Body
@@ -288,7 +289,7 @@ convPParamsToScriptIntegrityHash mTxProtocolParams redeemers datums languages =
             && null languages
   if shouldCalculateHash
     then do
-      pp <- maybe (Left MakeUnsignedTxMissingProtocolParams) Right mTxProtocolParams
+      pp <- liftMaybe MakeUnsignedTxMissingProtocolParams mTxProtocolParams
       pure $
         SJust $
           L.hashScriptIntegrity $

cardano-api/test/cardano-api-test/Test/Cardano/Api/Experimental/Fee.hs

@@ -15,12 +15,14 @@ import Cardano.Api.Experimental qualified as Exp
 import Cardano.Api.Experimental.Era (convert)
 import Cardano.Api.Experimental.Tx qualified as Exp
 import Cardano.Api.Ledger qualified as L
+import Cardano.Api.Monad.Error (failEither)
 
 import Cardano.Ledger.Api qualified as UnexportedLedger
 import Cardano.Ledger.Core qualified as L
 import Cardano.Ledger.Mary.Value qualified as Mary
 import Cardano.Ledger.Tools qualified as L (calcMinFeeTx)
 
+import Data.Bifunctor (first)
 import Data.Foldable (toList)
 import Data.Map.Strict qualified as Map
 import Data.Sequence.Strict qualified as Seq
@@ -387,9 +389,8 @@ genTinySurplusTx era = Exp.obtainCommonConstraints era $ do
           & Exp.setTxIns [(txIn, Exp.AnyKeyWitnessPlaceholder)]
           & Exp.setTxOuts [sendTxOut]
           & Exp.setTxFee 0
-  unsignedTx <- case Exp.makeUnsignedTx era txBodyContent of
-    Left err -> fail $ "makeUnsignedTx: " <> show err
-    Right tx -> return tx
+  unsignedTx <-
+    failEither . first (("makeUnsignedTx: " <>) . show) $ Exp.makeUnsignedTx era txBodyContent
   let
     -- Compute F1 via case match on UnsignedTx (needed to bring EraTx into scope)
     L.Coin f1 = case unsignedTx of