Skip to content

Commit f7a6ab5

Browse files
committed
Remove HasCallStack from constraint helpers, pool params, and case functions
These functions either have temporary Dijkstra era placeholders (which will be removed when Dijkstra is supported) or validation TODOs that should be replaced with proper error handling rather than HasCallStack.
1 parent f05438d commit f7a6ab5

7 files changed

Lines changed: 14 additions & 22 deletions

File tree

cardano-api/src/Cardano/Api/Certificate/Internal.hs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -652,7 +652,7 @@ fromShelleyCertificate
652652
fromShelleyCertificate =
653653
caseShelleyToBabbageOrConwayEraOnwards ShelleyRelatedCertificate ConwayCertificate
654654

655-
toShelleyPoolParams :: HasCallStack => StakePoolParameters -> Ledger.StakePoolParams
655+
toShelleyPoolParams :: StakePoolParameters -> Ledger.StakePoolParams
656656
toShelleyPoolParams
657657
StakePoolParameters
658658
{ stakePoolId = StakePoolKeyHash poolkh
@@ -725,8 +725,7 @@ toShelleyPoolParams
725725
Ledger.textToUrl (Text.length url) url
726726

727727
fromShelleyPoolParams
728-
:: HasCallStack
729-
=> Ledger.StakePoolParams
728+
:: Ledger.StakePoolParams
730729
-> StakePoolParameters
731730
fromShelleyPoolParams
732731
Ledger.StakePoolParams

cardano-api/src/Cardano/Api/Era/Internal/Case.hs

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,9 @@ import Cardano.Api.Era.Internal.Eon.ShelleyToAlonzoEra
3535
import Cardano.Api.Era.Internal.Eon.ShelleyToBabbageEra
3636
import Cardano.Api.Era.Internal.Eon.ShelleyToMaryEra
3737

38-
import GHC.Stack (HasCallStack)
39-
4038
-- | @caseByronOrShelleyBasedEra f g era@ returns @f@ in Byron and applies @g@ to Shelley-based eras.
4139
caseByronOrShelleyBasedEra
42-
:: HasCallStack
40+
:: ()
4341
=> a
4442
-> (ShelleyBasedEraConstraints era => ShelleyBasedEra era -> a)
4543
-> CardanoEra era
@@ -59,7 +57,7 @@ caseByronOrShelleyBasedEra l r = \case
5957
-- | @caseByronToAlonzoOrBabbageEraOnwards f g era@ applies @f@ to byron, shelley, allegra, mary, and alonzo;
6058
-- and @g@ to babbage and later eras.
6159
caseByronToAlonzoOrBabbageEraOnwards
62-
:: HasCallStack
60+
:: ()
6361
=> (ByronToAlonzoEraConstraints era => ByronToAlonzoEra era -> a)
6462
-> (BabbageEraOnwardsConstraints era => BabbageEraOnwards era -> a)
6563
-> CardanoEra era
@@ -77,7 +75,7 @@ caseByronToAlonzoOrBabbageEraOnwards l r = \case
7775
-- | @caseShelleyEraOnlyOrAllegraEraOnwards f g era@ applies @f@ to shelley;
7876
-- and applies @g@ to allegra and later eras.
7977
caseShelleyEraOnlyOrAllegraEraOnwards
80-
:: HasCallStack
78+
:: ()
8179
=> (ShelleyEraOnlyConstraints era => ShelleyEraOnly era -> a)
8280
-> (AllegraEraOnwardsConstraints era => AllegraEraOnwards era -> a)
8381
-> ShelleyBasedEra era
@@ -94,7 +92,7 @@ caseShelleyEraOnlyOrAllegraEraOnwards l r = \case
9492
-- | @caseShelleyToAllegraOrMaryEraOnwards f g era@ applies @f@ to shelley and allegra;
9593
-- and applies @g@ to mary and later eras.
9694
caseShelleyToAllegraOrMaryEraOnwards
97-
:: HasCallStack
95+
:: ()
9896
=> (ShelleyToAllegraEraConstraints era => ShelleyToAllegraEra era -> a)
9997
-> (MaryEraOnwardsConstraints era => MaryEraOnwards era -> a)
10098
-> ShelleyBasedEra era
@@ -111,7 +109,7 @@ caseShelleyToAllegraOrMaryEraOnwards l r = \case
111109
-- | @caseShelleyToMaryOrAlonzoEraOnwards f g era@ applies @f@ to shelley, allegra, and mary;
112110
-- and applies @g@ to alonzo and later eras.
113111
caseShelleyToMaryOrAlonzoEraOnwards
114-
:: HasCallStack
112+
:: ()
115113
=> (ShelleyToMaryEraConstraints era => ShelleyToMaryEra era -> a)
116114
-> (AlonzoEraOnwardsConstraints era => AlonzoEraOnwards era -> a)
117115
-> ShelleyBasedEra era
@@ -128,7 +126,7 @@ caseShelleyToMaryOrAlonzoEraOnwards l r = \case
128126
-- | @caseShelleyToAlonzoOrBabbageEraOnwards f g era@ applies @f@ to shelley, allegra, mary, and alonzo;
129127
-- and applies @g@ to babbage and later eras.
130128
caseShelleyToAlonzoOrBabbageEraOnwards
131-
:: HasCallStack
129+
:: ()
132130
=> (ShelleyToAlonzoEraConstraints era => ShelleyToAlonzoEra era -> a)
133131
-> (BabbageEraOnwardsConstraints era => BabbageEraOnwards era -> a)
134132
-> ShelleyBasedEra era
@@ -145,7 +143,7 @@ caseShelleyToAlonzoOrBabbageEraOnwards l r = \case
145143
-- | @caseShelleyToBabbageOrConwayEraOnwards f g era@ applies @f@ to eras before conway;
146144
-- and applies @g@ to conway and later eras.
147145
caseShelleyToBabbageOrConwayEraOnwards
148-
:: HasCallStack
146+
:: ()
149147
=> (ShelleyToBabbageEraConstraints era => ShelleyToBabbageEra era -> a)
150148
-> (ConwayEraOnwardsConstraints era => ConwayEraOnwards era -> a)
151149
-> ShelleyBasedEra era

cardano-api/src/Cardano/Api/Era/Internal/Eon/AllegraEraOnwards.hs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ import Ouroboros.Consensus.Shelley.Ledger qualified as Consensus
3939
import Data.Aeson
4040
import Data.Type.Equality
4141
import Data.Typeable (Typeable)
42-
import GHC.Stack (HasCallStack)
4342

4443
data AllegraEraOnwards era where
4544
AllegraEraOnwardsAllegra :: AllegraEraOnwards AllegraEra
@@ -111,7 +110,7 @@ type AllegraEraOnwardsConstraints era =
111110
)
112111

113112
allegraEraOnwardsConstraints
114-
:: HasCallStack
113+
:: ()
115114
=> AllegraEraOnwards era
116115
-> (AllegraEraOnwardsConstraints era => a)
117116
-> a

cardano-api/src/Cardano/Api/Era/Internal/Eon/BabbageEraOnwards.hs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ import Ouroboros.Consensus.Shelley.Ledger qualified as Consensus
4747
import Data.Aeson
4848
import Data.Type.Equality
4949
import Data.Typeable (Typeable)
50-
import GHC.Stack (HasCallStack)
5150

5251
data BabbageEraOnwards era where
5352
BabbageEraOnwardsBabbage :: BabbageEraOnwards BabbageEra
@@ -131,7 +130,7 @@ type BabbageEraOnwardsConstraints era =
131130
)
132131

133132
babbageEraOnwardsConstraints
134-
:: HasCallStack
133+
:: ()
135134
=> BabbageEraOnwards era
136135
-> (BabbageEraOnwardsConstraints era => a)
137136
-> a

cardano-api/src/Cardano/Api/Era/Internal/Eon/ConwayEraOnwards.hs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ import Ouroboros.Consensus.Shelley.Ledger qualified as Consensus
4949
import Data.Aeson
5050
import Data.Type.Equality
5151
import Data.Typeable (Typeable)
52-
import GHC.Stack (HasCallStack)
5352

5453
data ConwayEraOnwards era where
5554
ConwayEraOnwardsConway :: ConwayEraOnwards ConwayEra
@@ -140,7 +139,7 @@ type ConwayEraOnwardsConstraints era =
140139
)
141140

142141
conwayEraOnwardsConstraints
143-
:: HasCallStack
142+
:: ()
144143
=> ConwayEraOnwards era
145144
-> (ConwayEraOnwardsConstraints era => a)
146145
-> a

cardano-api/src/Cardano/Api/Era/Internal/Eon/MaryEraOnwards.hs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ import Ouroboros.Consensus.Shelley.Ledger qualified as Consensus
4242
import Data.Aeson
4343
import Data.Type.Equality
4444
import Data.Typeable (Typeable)
45-
import GHC.Stack (HasCallStack)
4645

4746
data MaryEraOnwards era where
4847
MaryEraOnwardsMary :: MaryEraOnwards MaryEra
@@ -113,7 +112,7 @@ type MaryEraOnwardsConstraints era =
113112
)
114113

115114
maryEraOnwardsConstraints
116-
:: HasCallStack
115+
:: ()
117116
=> MaryEraOnwards era
118117
-> (MaryEraOnwardsConstraints era => a)
119118
-> a

cardano-api/src/Cardano/Api/Era/Internal/Eon/ShelleyBasedEra.hs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@ import Data.Aeson (FromJSON (..), ToJSON, toJSON, withText)
6262
import Data.Text qualified as Text
6363
import Data.Type.Equality (TestEquality (..), (:~:) (Refl), type (==))
6464
import Data.Typeable (Typeable)
65-
import GHC.Stack (HasCallStack)
6665
import Text.Pretty (Pretty (..))
6766

6867
-- | Determine the value to use for a feature in a given 'ShelleyBasedEra'.
@@ -251,7 +250,7 @@ type ShelleyBasedEraConstraints era =
251250
)
252251

253252
shelleyBasedEraConstraints
254-
:: HasCallStack
253+
:: ()
255254
=> ShelleyBasedEra era
256255
-> (ShelleyBasedEraConstraints era => a)
257256
-> a

0 commit comments

Comments
 (0)