Make continuation construction clearer in query monadic interface#815
Merged
Conversation
Jimbo4350
requested review from
CarlosLopezDeLara,
carbolymer,
dcoutts,
disassembler,
erikd,
kevinhammond,
newhoggy and
palas
as code owners
Jimbo4350
force-pushed
the
jordan/LocalStateQueryExpr-refactor
branch
from
158e36b to
9de588a
Compare
carbolymer
reviewed
Apr 16, 2025
| void $ atomically waitDone -- Wait for all protocols to complete before exiting. | ||
| pure $ Net.Query.SendMsgRelease $ pure $ Net.Query.SendMsgDone () | ||
| { Net.Query.recvMsgAcquired = do | ||
| allQueries <- pure $ runReaderT (runLocalStateQueryExpr f) ntcVersion |
Contributor
There was a problem hiding this comment.
Suggested change
| allQueries <- pure $ runReaderT (runLocalStateQueryExpr f) ntcVersion | |
| let allQueries = runReaderT (runLocalStateQueryExpr f) ntcVersion |
carbolymer
approved these changes
Apr 16, 2025
Jimbo4350
force-pushed
the
jordan/LocalStateQueryExpr-refactor
branch
from
9de588a to
d32a888
Compare
Jimbo4350
force-pushed
the
jordan/LocalStateQueryExpr-refactor
branch
from
d32a888 to
2fe9ab8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist