Remove BabbageEra from experimental Era type#828
Merged
Conversation
palas
requested review from
Jimbo4350,
carbolymer,
dcoutts,
erikd,
kevinhammond and
newhoggy
as code owners
carbolymer
reviewed
Apr 25, 2025
palas
force-pushed
the
remove-babbage-from-experimental-era-type
branch
from
9bc4a0d to
b03d68a
Compare
palas
force-pushed
the
remove-babbage-from-experimental-era-type
branch
from
b03d68a to
8953632
Compare
carbolymer
approved these changes
Apr 25, 2025
Jimbo4350
approved these changes
Apr 25, 2025
Contributor
Jimbo4350
left a comment
Jimbo4350
left a comment
There was a problem hiding this comment.
Nice, how does this look in cardano-cli?
Contributor
Author
It just affects two lines, where there was a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Context
This PR addresses #827. It is part of an effort to propagate the experimental API through
cardano-cli. Because Babbage era is deprecated we are removing it from the experimental API.How to trust this PR
Check just the right things are removed and the updates make sense. The fact that it typechecks already gives a lot of assurance in this particular case.
Checklist