UTxO-HD targeting main#1011
Conversation
f717421 to
e3b99e7
Compare
| allow-newer: *:time | ||
|
|
||
| constraints: any.text source | ||
| -- Temporary workaround for problem with cabal-doctest |
There was a problem hiding this comment.
Points for the comment 👍. Which repo is having issues with cabal-doctest?
There was a problem hiding this comment.
Ah that is from @neilmayhew's commits. Mine is just the last one. But I think it is consensus the one that had this problem. https://github.com/IntersectMBO/ouroboros-consensus/blob/main/cabal.project#L48-L49
There was a problem hiding this comment.
The problem occurred in api, cli and node as well as consensus. I think the problem arises because of the extra-packages: Cabal line. This allows a newer version of Cabal than would otherwise be chosen by the solver, which breaks cabal-doctest. However, there's been a release of cabal-doctest since I made this change, so it may be possible to drop it now.
There was a problem hiding this comment.
I tested this, and the constraint can be taken out in consensus, api and cli. However, it can't be taken out in node because it depends (indirectly) on entropy which uses a custom Setup.hs that isn't compatible with Cabal-3.14 when built with ghc8107.
There was a problem hiding this comment.
Actually, that isn't correct. It's a haskell.nix problem. The cabal file for entropy has setup-depends: Cabal >= 1.10 && < 3.13 and when building with cabal outside of haskell.nix it uses Cabal-3.12.1.0 as expected, with both ghc8 and ghc9. However, haskell.nix uses Cabal-3.14.1.0 for both.
However, this affects only node (⟶ systemd ⟶ uuid ⟶ entropy) so the constraint can be removed in consensus, api and cli.
It needs to be retained in node, but I'll push a commit that changes the comment.
There was a problem hiding this comment.
I've pushed a commit to my branch in cli that removes the constraint. You can just rebase on that.
There was a problem hiding this comment.
I've discovered that the problem can be worked around more cleanly in node by updating the Hackage index, because entropy was updated to be compatible with Cabal-3.14 on Jan 1.
e3b99e7 to
e79f198
Compare
e79f198 to
5e3738c
Compare
b721e70 to
f2b24b8
Compare
f2b24b8 to
7e007c9
Compare
7e007c9 to
d4e549b
Compare
|
This PR is stale because it has been open 45 days with no activity. |
Changelog
Context
See the cardano-api PR
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist