Skip to content

Make sure we're using indexes during rollbacks 13.7.0.1 #2084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kderme wants to merge 1 commit into from
Closed

Make sure we're using indexes during rollbacks 13.7.0.1 #2084

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 59 additions & 8 deletions cardano-db/src/Cardano/Db/Statement/MinIds.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,9 @@ import Cardano.Db.Types (DbM)
-- RAW INT64 QUERIES (for rollback operations)
---------------------------------------------------------------------------

-- | Find the minimum ID in a table - returns raw Int64
-- | Find the minimum ID in a table. Fetches all matching IDs (up to 10000)
-- and finds the minimum in Haskell to avoid bad query plans with ORDER BY/MIN.
-- Falls back to the original ORDER BY query if there are too many results.
queryMinRefIdStmt ::
forall a b.
DbInfo a =>
Expand All @@ -47,8 +49,29 @@ queryMinRefIdStmt ::
HsqlE.Params b ->
-- | Raw ID decoder (Int64)
HsqlD.Row Int64 ->
HsqlStmt.Statement b [Int64]
queryMinRefIdStmt fieldName encoder _idDecoder =
HsqlStmt.Statement sql encoder decoder True
where
validCol = validateColumn @a fieldName
sql =
TextEnc.encodeUtf8 $
Text.concat
[ "SELECT id"
, " FROM " <> tableName (Proxy @a)
, " WHERE " <> validCol <> " >= $1"
, " LIMIT 10000"
]
decoder = HsqlD.rowList (HsqlD.column (HsqlD.nonNullable HsqlD.int8))

queryMinRefIdFallbackStmt ::
forall a b.
DbInfo a =>
Text.Text ->
HsqlE.Params b ->
HsqlD.Row Int64 ->
HsqlStmt.Statement b (Maybe Int64)
queryMinRefIdStmt fieldName encoder idDecoder =
queryMinRefIdFallbackStmt fieldName encoder idDecoder =
HsqlStmt.Statement sql encoder decoder True
where
validCol = validateColumn @a fieldName
Expand All @@ -73,8 +96,11 @@ queryMinRefId ::
-- | Parameter encoder
HsqlE.Params b ->
DbM (Maybe Int64)
queryMinRefId fieldName value encoder =
runSession mkDbCallStack $ HsqlSes.statement value (queryMinRefIdStmt @a fieldName encoder rawInt64Decoder)
queryMinRefId fieldName value encoder = do
ids <- runSession mkDbCallStack $ HsqlSes.statement value (queryMinRefIdStmt @a fieldName encoder rawInt64Decoder)
if length ids >= 10000
then runSession mkDbCallStack $ HsqlSes.statement value (queryMinRefIdFallbackStmt @a fieldName encoder rawInt64Decoder)
else pure $ if null ids then Nothing else Just (minimum ids)
where
rawInt64Decoder = HsqlD.column (HsqlD.nonNullable HsqlD.int8)

Expand All @@ -91,12 +117,33 @@ queryMinRefIdNullableStmt ::
HsqlE.Params b ->
-- | Raw ID decoder (Int64)
HsqlD.Row Int64 ->
HsqlStmt.Statement b [Int64]
queryMinRefIdNullableStmt fieldName encoder _idDecoder =
HsqlStmt.Statement sql encoder decoder True
where
validCol = validateColumn @a fieldName
sql =
TextEnc.encodeUtf8 $
Text.concat
[ "SELECT id"
, " FROM " <> tableName (Proxy @a)
, " WHERE " <> validCol <> " IS NOT NULL"
, " AND " <> validCol <> " >= $1"
, " LIMIT 10000"
]
decoder = HsqlD.rowList (HsqlD.column (HsqlD.nonNullable HsqlD.int8))

queryMinRefIdNullableFallbackStmt ::
forall a b.
DbInfo a =>
Text.Text ->
HsqlE.Params b ->
HsqlD.Row Int64 ->
HsqlStmt.Statement b (Maybe Int64)
queryMinRefIdNullableStmt fieldName encoder idDecoder =
queryMinRefIdNullableFallbackStmt fieldName encoder idDecoder =
HsqlStmt.Statement sql encoder decoder True
where
validCol = validateColumn @a fieldName
decoder = HsqlD.rowMaybe idDecoder
sql =
TextEnc.encodeUtf8 $
Text.concat
Expand All @@ -107,6 +154,7 @@ queryMinRefIdNullableStmt fieldName encoder idDecoder =
, " ORDER BY id ASC"
, " LIMIT 1"
]
decoder = HsqlD.rowMaybe idDecoder

queryMinRefIdNullable ::
forall a b.
Expand All @@ -118,8 +166,11 @@ queryMinRefIdNullable ::
-- | Parameter encoder
HsqlE.Params b ->
DbM (Maybe Int64)
queryMinRefIdNullable fieldName value encoder =
runSession mkDbCallStack $ HsqlSes.statement value (queryMinRefIdNullableStmt @a fieldName encoder rawInt64Decoder)
queryMinRefIdNullable fieldName value encoder = do
ids <- runSession mkDbCallStack $ HsqlSes.statement value (queryMinRefIdNullableStmt @a fieldName encoder rawInt64Decoder)
if length ids >= 10000
then runSession mkDbCallStack $ HsqlSes.statement value (queryMinRefIdNullableFallbackStmt @a fieldName encoder rawInt64Decoder)
else pure $ if null ids then Nothing else Just (minimum ids)
where
rawInt64Decoder = HsqlD.column (HsqlD.nonNullable HsqlD.int8)

Expand Down
Loading