Make ZeroTreasuryWithdrawals a permanent check in gov state transation rule

In `conwayGovTransition`, we remove the condition on
`hardforkConwayBootstrapPhase` for checking `ZeroTreasuryWithdrawals`.

We then replayed the preview, preprod and mainnet public chains with
this change which guarentees there were no empty treasury withdrawals
pre-Conway era.

Author: koslambrou

eras/conway/impl/src/Cardano/Ledger/Conway/Rules/Gov.hs

@@ -546,9 +546,8 @@ conwayGovTransition = do
             -- Guardrails script hash check
             runTest $ checkGuardrailsScriptHash @era constitutionPolicy proposalPolicy
 
-            unless (hardforkConwayBootstrapPhase $ pp ^. ppProtocolVersionL) $
-              -- The sum of all withdrawals must be positive
-              F.fold wdrls /= mempty ?! (injectFailure . ZeroTreasuryWithdrawals) pProcGovAction
+            -- The sum of all withdrawals must be positive
+            F.fold wdrls /= mempty ?! (injectFailure . ZeroTreasuryWithdrawals) pProcGovAction
           UpdateCommittee _mPrevGovActionId membersToRemove membersToAdd _qrm -> do
             let conflicting = Set.intersection (Map.keysSet membersToAdd) membersToRemove
              in failOnNonEmptySet conflicting (injectFailure . ConflictingCommitteeUpdate)

eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/GovSpec.hs

@@ -1105,28 +1105,31 @@ withdrawalsSpec =
               }
 
     it "Fails for empty withdrawals" $ do
-      mkTreasuryWithdrawalsGovAction [] >>= expectZeroTreasuryFailurePostBootstrap
+      mkTreasuryWithdrawalsGovAction [] >>= expectZeroTreasuryFailure
 
       accountAddress1 <- registerAccountAddress
-      mkTreasuryWithdrawalsGovAction [(accountAddress1, zero)] >>= expectZeroTreasuryFailurePostBootstrap
+      mkTreasuryWithdrawalsGovAction [(accountAddress1, zero)] >>= expectZeroTreasuryFailure
 
       accountAddress2 <- registerAccountAddress
       let withdrawals = [(accountAddress1, zero), (accountAddress2, zero)]
 
-      mkTreasuryWithdrawalsGovAction withdrawals >>= expectZeroTreasuryFailurePostBootstrap
+      mkTreasuryWithdrawalsGovAction withdrawals >>= expectZeroTreasuryFailure
 
       wdrls <- mkTreasuryWithdrawalsGovAction $ withdrawals ++ [(accountAddress2, Coin 100_000)]
       proposal <- mkProposal wdrls
       submitBootstrapAwareFailingProposal_ proposal $
         FailBootstrap [disallowedProposalFailure proposal]
   where
-    expectZeroTreasuryFailurePostBootstrap wdrls = do
+    expectZeroTreasuryFailure wdrls = do
       proposal <- mkProposal wdrls
       void $
         submitBootstrapAwareFailingProposal proposal $
           FailBootstrapAndPostBootstrap $
             FailBoth
-              { bootstrapFailures = [disallowedProposalFailure proposal]
+              { bootstrapFailures =
+                  [ disallowedProposalFailure proposal
+                  , injectFailure $ ZeroTreasuryWithdrawals wdrls
+                  ]
               , postBootstrapFailures = [injectFailure $ ZeroTreasuryWithdrawals wdrls]
               }