Adding first standalone predicate failure AccountAlreadyRegistered

Thsi commit serves as an example of a pattern we will use for all
ledger predicate failures for all era, except Byron.

Author: lehins

eras/allegra/impl/src/Cardano/Ledger/Allegra/Rules/Deleg.hs

@@ -8,9 +8,13 @@ module Cardano.Ledger.Allegra.Rules.Deleg () where
 import Cardano.Ledger.Allegra.Era (AllegraEra)
 import Cardano.Ledger.Core
 import Cardano.Ledger.Shelley.Rules (
-  ShelleyDelegPredFailure,
+  AccountAlreadyRegistered,
+  ShelleyDelegPredFailure (..),
  )
 
 type instance EraRuleFailure "DELEG" AllegraEra = ShelleyDelegPredFailure AllegraEra
 
 instance InjectRuleFailure "DELEG" ShelleyDelegPredFailure AllegraEra
+
+instance InjectRuleFailure "DELEG" AccountAlreadyRegistered AllegraEra where
+  injectFailure = DelegAccountAlreadyRegistered

eras/allegra/impl/src/Cardano/Ledger/Allegra/Rules/Ledger.hs

@@ -10,9 +10,10 @@ import Cardano.Ledger.Allegra.Rules.Delegs ()
 import Cardano.Ledger.Allegra.Rules.Utxow ()
 import Cardano.Ledger.Core
 import Cardano.Ledger.Shelley.Rules (
+  AccountAlreadyRegistered,
   ShelleyDelegPredFailure,
-  ShelleyDelegsPredFailure,
-  ShelleyDelplPredFailure,
+  ShelleyDelegsPredFailure (..),
+  ShelleyDelplPredFailure (..),
   ShelleyLedgerEvent,
   ShelleyLedgerPredFailure (..),
   ShelleyPoolPredFailure,
@@ -23,6 +24,9 @@ import Cardano.Ledger.Shelley.Rules (
 
 type instance EraRuleFailure "LEDGER" AllegraEra = ShelleyLedgerPredFailure AllegraEra
 
+instance InjectRuleFailure "LEDGER" AccountAlreadyRegistered AllegraEra where
+  injectFailure = DelegsFailure . DelplFailure . DelegFailure . injectFailure
+
 instance InjectRuleFailure "LEDGER" ShelleyLedgerPredFailure AllegraEra
 
 instance InjectRuleFailure "LEDGER" ShelleyUtxowPredFailure AllegraEra where

eras/alonzo/impl/src/Cardano/Ledger/Alonzo/Rules/Deleg.hs

@@ -7,8 +7,14 @@ module Cardano.Ledger.Alonzo.Rules.Deleg () where
 
 import Cardano.Ledger.Alonzo.Era (AlonzoEra)
 import Cardano.Ledger.Core
-import Cardano.Ledger.Shelley.Rules (ShelleyDelegPredFailure)
+import Cardano.Ledger.Shelley.Rules (
+  AccountAlreadyRegistered,
+  ShelleyDelegPredFailure (..),
+ )
 
 type instance EraRuleFailure "DELEG" AlonzoEra = ShelleyDelegPredFailure AlonzoEra
 
 instance InjectRuleFailure "DELEG" ShelleyDelegPredFailure AlonzoEra
+
+instance InjectRuleFailure "DELEG" AccountAlreadyRegistered AlonzoEra where
+  injectFailure = DelegAccountAlreadyRegistered

eras/alonzo/impl/src/Cardano/Ledger/Alonzo/Rules/Ledger.hs

@@ -30,11 +30,12 @@ import Cardano.Ledger.Shelley.LedgerState (
   UTxOState (..),
  )
 import Cardano.Ledger.Shelley.Rules (
+  AccountAlreadyRegistered,
   DelegsEnv (..),
   ShelleyDELEGS,
   ShelleyDelegPredFailure,
   ShelleyDelegsEvent,
-  ShelleyDelegsPredFailure,
+  ShelleyDelegsPredFailure (..),
   ShelleyDelplPredFailure (..),
   ShelleyLEDGERS,
   ShelleyPoolPredFailure,
@@ -71,6 +72,9 @@ import Lens.Micro
 
 type instance EraRuleFailure "LEDGER" AlonzoEra = ShelleyLedgerPredFailure AlonzoEra
 
+instance InjectRuleFailure "LEDGER" AccountAlreadyRegistered AlonzoEra where
+  injectFailure = DelegsFailure . DelplFailure . DelegFailure . injectFailure
+
 instance InjectRuleFailure "LEDGER" ShelleyLedgerPredFailure AlonzoEra
 
 instance InjectRuleFailure "LEDGER" AlonzoUtxowPredFailure AlonzoEra where

eras/babbage/impl/src/Cardano/Ledger/Babbage/Rules/Deleg.hs

@@ -8,9 +8,13 @@ module Cardano.Ledger.Babbage.Rules.Deleg () where
 import Cardano.Ledger.Babbage.Era (BabbageEra)
 import Cardano.Ledger.Core
 import Cardano.Ledger.Shelley.Rules (
-  ShelleyDelegPredFailure,
+  AccountAlreadyRegistered,
+  ShelleyDelegPredFailure (..),
  )
 
 type instance EraRuleFailure "DELEG" BabbageEra = ShelleyDelegPredFailure BabbageEra
 
 instance InjectRuleFailure "DELEG" ShelleyDelegPredFailure BabbageEra
+
+instance InjectRuleFailure "DELEG" AccountAlreadyRegistered BabbageEra where
+  injectFailure = DelegAccountAlreadyRegistered

eras/babbage/impl/src/Cardano/Ledger/Babbage/Rules/Ledger.hs

@@ -32,13 +32,14 @@ import Cardano.Ledger.Shelley.LedgerState (
   UTxOState (..),
  )
 import Cardano.Ledger.Shelley.Rules (
+  AccountAlreadyRegistered,
   DelegsEnv (..),
   LedgerEnv (..),
   ShelleyDELEGS,
   ShelleyDelegPredFailure,
   ShelleyDelegsEvent,
-  ShelleyDelegsPredFailure,
-  ShelleyDelplPredFailure,
+  ShelleyDelegsPredFailure (..),
+  ShelleyDelplPredFailure (..),
   ShelleyLEDGERS,
   ShelleyLedgerEvent (..),
   ShelleyLedgerPredFailure (..),
@@ -65,6 +66,9 @@ import Data.Sequence (Seq)
 
 type instance EraRuleFailure "LEDGER" BabbageEra = ShelleyLedgerPredFailure BabbageEra
 
+instance InjectRuleFailure "LEDGER" AccountAlreadyRegistered BabbageEra where
+  injectFailure = DelegsFailure . DelplFailure . DelegFailure . injectFailure
+
 instance InjectRuleFailure "LEDGER" ShelleyLedgerPredFailure BabbageEra
 
 instance InjectRuleFailure "LEDGER" BabbageUtxowPredFailure BabbageEra where

eras/conway/impl/src/Cardano/Ledger/Conway/Rules/Deleg.hs

@@ -56,6 +56,7 @@ import Cardano.Ledger.Conway.TxCert (
  )
 import Cardano.Ledger.Credential (Credential)
 import Cardano.Ledger.DRep
+import qualified Cardano.Ledger.Shelley.Rules as Shelley
 import Control.DeepSeq (NFData)
 import Control.Monad (forM_, guard, unless)
 import Control.State.Transition (
@@ -104,7 +105,7 @@ deriving instance Show (PParams era) => Show (ConwayDelegEnv era)
 
 data ConwayDelegPredFailure era
   = IncorrectDepositDELEG Coin
-  | StakeKeyRegisteredDELEG (Credential Staking)
+  | DelegAccountAlreadyRegistered (Shelley.AccountAlreadyRegistered era)
   | StakeKeyNotRegisteredDELEG (Credential Staking)
   | StakeKeyHasNonZeroAccountBalanceDELEG Coin
   | DelegateeDRepNotRegisteredDELEG (Credential DRepRole)
@@ -117,6 +118,9 @@ type instance EraRuleFailure "DELEG" ConwayEra = ConwayDelegPredFailure ConwayEr
 
 type instance EraRuleEvent "DELEG" ConwayEra = VoidEraRule "DELEG" ConwayEra
 
+instance InjectRuleFailure "DELEG" Shelley.AccountAlreadyRegistered ConwayEra where
+  injectFailure = DelegAccountAlreadyRegistered
+
 instance InjectRuleFailure "DELEG" ConwayDelegPredFailure ConwayEra
 
 instance NFData (ConwayDelegPredFailure era)
@@ -126,8 +130,8 @@ instance Era era => EncCBOR (ConwayDelegPredFailure era) where
     encode . \case
       IncorrectDepositDELEG mCoin ->
         Sum (IncorrectDepositDELEG @era) 1 !> To mCoin
-      StakeKeyRegisteredDELEG stakeCred ->
-        Sum (StakeKeyRegisteredDELEG @era) 2 !> To stakeCred
+      DelegAccountAlreadyRegistered stakeCred ->
+        Sum (DelegAccountAlreadyRegistered @era) 2 !> To stakeCred
       StakeKeyNotRegisteredDELEG stakeCred ->
         Sum (StakeKeyNotRegisteredDELEG @era) 3 !> To stakeCred
       StakeKeyHasNonZeroAccountBalanceDELEG mCoin ->
@@ -144,7 +148,7 @@ instance Era era => EncCBOR (ConwayDelegPredFailure era) where
 instance Era era => DecCBOR (ConwayDelegPredFailure era) where
   decCBOR = decode $ Summands "ConwayDelegPredFailure" $ \case
     1 -> SumD IncorrectDepositDELEG <! From
-    2 -> SumD StakeKeyRegisteredDELEG <! From
+    2 -> SumD DelegAccountAlreadyRegistered <! From
     3 -> SumD StakeKeyNotRegisteredDELEG <! From
     4 -> SumD StakeKeyHasNonZeroAccountBalanceDELEG <! From
     5 -> SumD DelegateeDRepNotRegisteredDELEG <! From
@@ -162,6 +166,7 @@ instance
   , Environment (EraRule "DELEG" era) ~ ConwayDelegEnv era
   , EraRule "DELEG" era ~ ConwayDELEG era
   , InjectRuleFailure "DELEG" ConwayDelegPredFailure era
+  , InjectRuleFailure "DELEG" Shelley.AccountAlreadyRegistered era
   ) =>
   STS (ConwayDELEG era)
   where
@@ -182,6 +187,7 @@ conwayDelegTransition ::
   , Environment (EraRule rule era) ~ ConwayDelegEnv era
   , State (EraRule rule era) ~ CertState era
   , InjectRuleFailure rule ConwayDelegPredFailure era
+  , InjectRuleFailure rule Shelley.AccountAlreadyRegistered era
   ) =>
   TransitionRule (EraRule rule era)
 conwayDelegTransition = do
@@ -209,9 +215,6 @@ conwayDelegTransition = do
                       }
                 )
             else injectFailure $ IncorrectDepositDELEG deposit
-    checkStakeKeyNotRegistered stakeCred =
-      not (isAccountRegistered stakeCred accounts)
-        ?! injectFailure (StakeKeyRegisteredDELEG stakeCred)
     checkStakeDelegateeRegistered =
       let checkPoolRegistered targetPool =
             targetPool
@@ -232,7 +235,7 @@ conwayDelegTransition = do
   case cert of
     ConwayRegCert stakeCred sMayDeposit -> do
       forM_ sMayDeposit checkDepositAgainstPParams
-      checkStakeKeyNotRegistered stakeCred
+      Shelley.checkAccountAlreadyRegistered @rule accounts stakeCred
       pure $
         certState
           & certDStateL . accountsL
@@ -292,7 +295,7 @@ conwayDelegTransition = do
               certState
     ConwayRegDelegCert stakeCred delegatee deposit -> do
       checkDepositAgainstPParams deposit
-      checkStakeKeyNotRegistered stakeCred
+      Shelley.checkAccountAlreadyRegistered accounts stakeCred
       checkStakeDelegateeRegistered delegatee
       pure $
         processDelegationInternal (pvMajor pv < natVersion @10) stakeCred Nothing delegatee $

eras/conway/impl/src/Cardano/Ledger/Conway/Rules/Ledger.hs

@@ -118,6 +118,7 @@ import Cardano.Ledger.Shelley.Rules (
   shelleyLedgerAssertions,
   testIncompleteAndMissingWithdrawals,
  )
+import qualified Cardano.Ledger.Shelley.Rules as Shelley
 import Cardano.Ledger.Slot (epochFromSlot)
 import Control.DeepSeq (NFData)
 import Control.Monad (unless)
@@ -151,6 +152,9 @@ type instance EraRuleFailure "LEDGER" ConwayEra = ConwayLedgerPredFailure Conway
 
 type instance EraRuleEvent "LEDGER" ConwayEra = ConwayLedgerEvent ConwayEra
 
+instance InjectRuleFailure "LEDGER" Shelley.AccountAlreadyRegistered ConwayEra where
+  injectFailure = ConwayCertsFailure . CertFailure . DelegFailure . injectFailure
+
 instance InjectRuleFailure "LEDGER" ConwayLedgerPredFailure ConwayEra
 
 instance InjectRuleFailure "LEDGER" ShelleyLedgerPredFailure ConwayEra where

eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/ImpTest.hs

@@ -1919,7 +1919,7 @@ instance InjectRuleFailure "CERT" ShelleyDelegPredFailure ConwayEra where
   injectFailure = DelegFailure . injectFailure
 
 instance InjectRuleFailure "DELEG" ShelleyDelegPredFailure ConwayEra where
-  injectFailure (Shelley.StakeKeyAlreadyRegisteredDELEG c) = StakeKeyRegisteredDELEG c
+  injectFailure (Shelley.DelegAccountAlreadyRegistered c) = DelegAccountAlreadyRegistered c
   injectFailure (Shelley.StakeKeyNotRegisteredDELEG c) = StakeKeyNotRegisteredDELEG c
   injectFailure (Shelley.StakeKeyNonZeroAccountBalanceDELEG c) = StakeKeyHasNonZeroAccountBalanceDELEG c
   injectFailure _ = error "Cannot inject ShelleyDelegPredFailure into ConwayEra"

eras/dijkstra/impl/src/Cardano/Ledger/Dijkstra/Rules/Deleg.hs

@@ -6,11 +6,16 @@
 module Cardano.Ledger.Dijkstra.Rules.Deleg () where
 
 import Cardano.Ledger.Conway.Rules (ConwayDelegPredFailure)
+import qualified Cardano.Ledger.Conway.Rules as Conway
 import Cardano.Ledger.Dijkstra.Core
 import Cardano.Ledger.Dijkstra.Era (DijkstraEra)
+import qualified Cardano.Ledger.Shelley.Rules as Shelley
 
 type instance EraRuleFailure "DELEG" DijkstraEra = ConwayDelegPredFailure DijkstraEra
 
 type instance EraRuleEvent "DELEG" DijkstraEra = VoidEraRule "DELEG" DijkstraEra
 
 instance InjectRuleFailure "DELEG" ConwayDelegPredFailure DijkstraEra
+
+instance InjectRuleFailure "DELEG" Shelley.AccountAlreadyRegistered DijkstraEra where
+  injectFailure = Conway.DelegAccountAlreadyRegistered