Skip to content

Fail PlutusV1-V3 translation for non-empty subTransactionsTxBody#5669

Merged
lehins merged 4 commits intomasterfrom
ldan/subtransactions-fail-plutus-translation
May 7, 2026
Merged

Fail PlutusV1-V3 translation for non-empty subTransactionsTxBody#5669
lehins merged 4 commits intomasterfrom
ldan/subtransactions-fail-plutus-translation

Conversation

@Lucsanszky
Copy link
Copy Markdown
Contributor

@Lucsanszky Lucsanszky commented Mar 23, 2026

Description

Resolves #5633

Checklist

  • Commits in meaningful sequence and with useful messages.
  • Tests added or updated when needed.
  • CHANGELOG.md files updated for packages with externally visible changes.
    NOTE: New section is never added with the code changes. (See RELEASING.md).
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary.
    NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
  • Code formatted (use scripts/fourmolize.sh).
  • Cabal files formatted (use scripts/cabal-format.sh).
  • CDDL files are up to date (use scripts/gen-cddl.sh)
  • hie.yaml updated (use scripts/gen-hie.sh).
  • Self-reviewed the diff.

@Lucsanszky Lucsanszky changed the base branch from master to lehins/memoize-transaction-validation March 23, 2026 22:58
@Lucsanszky Lucsanszky changed the title Ldan/subtransactions fail plutus translation Fail PlutusV1-V3 translation for non-empty subTransactionsTxBody Mar 23, 2026
Comment thread eras/dijkstra/impl/src/Cardano/Ledger/Dijkstra/TxInfo.hs Outdated
@lehins lehins force-pushed the lehins/memoize-transaction-validation branch 6 times, most recently from adef9ae to 7e175ac Compare April 21, 2026 06:23
@lehins lehins force-pushed the lehins/memoize-transaction-validation branch 3 times, most recently from 3b5a330 to 3594844 Compare April 24, 2026 08:52
Base automatically changed from lehins/memoize-transaction-validation to master April 24, 2026 11:24
@Lucsanszky Lucsanszky force-pushed the ldan/subtransactions-fail-plutus-translation branch from e1da532 to e1c4383 Compare May 4, 2026 21:14
@Lucsanszky Lucsanszky marked this pull request as ready for review May 4, 2026 21:31
@Lucsanszky Lucsanszky requested a review from a team as a code owner May 4, 2026 21:31
Copy link
Copy Markdown
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we need a new failure

Comment thread eras/dijkstra/impl/src/Cardano/Ledger/Dijkstra/TxInfo.hs Outdated
@Lucsanszky Lucsanszky force-pushed the ldan/subtransactions-fail-plutus-translation branch from e1c4383 to 67d3906 Compare May 5, 2026 13:59
@Lucsanszky Lucsanszky requested a review from lehins May 5, 2026 17:30
Comment thread eras/dijkstra/impl/CHANGELOG.md
Copy link
Copy Markdown
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, will let Alexey approve it since he had requested changes.

Comment thread eras/dijkstra/impl/src/Cardano/Ledger/Dijkstra/TxInfo.hs Outdated
Comment thread eras/dijkstra/impl/src/Cardano/Ledger/Dijkstra/TxInfo.hs
Copy link
Copy Markdown
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from usage of partial function this PR look good.

Comment thread eras/dijkstra/impl/src/Cardano/Ledger/Dijkstra/TxInfo.hs Outdated
Comment thread eras/dijkstra/impl/CHANGELOG.md
Comment thread eras/dijkstra/impl/src/Cardano/Ledger/Dijkstra/TxInfo.hs
@Lucsanszky Lucsanszky force-pushed the ldan/subtransactions-fail-plutus-translation branch from 131b1f4 to 8b60622 Compare May 6, 2026 09:14
@Lucsanszky Lucsanszky enabled auto-merge May 6, 2026 09:21
@Lucsanszky Lucsanszky requested a review from lehins May 6, 2026 13:33
Copy link
Copy Markdown
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Thank you!

@lehins lehins disabled auto-merge May 7, 2026 05:05
@lehins lehins merged commit 5f7ca3c into master May 7, 2026
64 checks passed
@lehins lehins deleted the ldan/subtransactions-fail-plutus-translation branch May 7, 2026 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fail Plutus translation with SubTransactions

3 participants