Add entities/accounts/v0 namespace#5699
Open
joaosreis wants to merge 3 commits intoIntersectMBO:masterfrom
Open
Add entities/accounts/v0 namespace#5699joaosreis wants to merge 3 commits intoIntersectMBO:masterfrom
joaosreis wants to merge 3 commits intoIntersectMBO:masterfrom
Conversation
lehins
reviewed
Apr 2, 2026
| & ppDRepActivityL .~ dRepActivity | ||
| & ppMinFeeRefScriptCostPerByteL .~ minFeeRefScriptCostPerByte | ||
| & ppProtocolVersionL .~ protVer | ||
| & ppTxFeePerByteL |
Collaborator
There was a problem hiding this comment.
Could you please fix the formatting. I suspect you are either using an old version of fourmolu or it is incorrectly setup.
joaosreis
force-pushed
the
joaosreis/canonical-accounts
branch
6 times, most recently
from
dc33c07 to
3c62159
Compare
joaosreis
force-pushed
the
joaosreis/canonical-accounts
branch
from
3c62159 to
aa24066
Compare
1 task
lehins
requested changes
Apr 8, 2026
Collaborator
lehins
left a comment
lehins
left a comment
There was a problem hiding this comment.
This is one of those types that needs a custom Canonical represnetation
| EntitiesAccountsIn <$> unpackM | ||
|
|
||
| newtype EntitiesAccountsOut era | ||
| = EntitiesAccountsOut (AccountState era) |
Collaborator
There was a problem hiding this comment.
This type requires a custom representation and type family from Ledger State cannot be reused, because:
- it is highly likely to change in the next era
- there are no guarantees that it will not change even in a current era, since it is not a type family that is used on chain.
Contributor
Author
There was a problem hiding this comment.
Added the CanonicalAccountState type and related instances.
joaosreis
force-pushed
the
joaosreis/canonical-accounts
branch
from
aa24066 to
f934b9b
Compare
joaosreis
force-pushed
the
joaosreis/canonical-accounts
branch
2 times, most recently
from
a19be25 to
1900527
Compare
joaosreis
force-pushed
the
joaosreis/canonical-accounts
branch
from
1900527 to
2ff46e1
Compare
joaosreis
force-pushed
the
joaosreis/canonical-accounts
branch
from
2ff46e1 to
d267190
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).