Refactor gov/proposals/v0 namespace to include the proposals order#5738
Open
joaosreis wants to merge 3 commits into
Open
Refactor gov/proposals/v0 namespace to include the proposals order#5738joaosreis wants to merge 3 commits into
joaosreis wants to merge 3 commits into
Conversation
joaosreis
force-pushed
the
joaosreis/canonical-gov-proposals-order
branch
from
913d283 to
4e5a34d
Compare
joaosreis
force-pushed
the
joaosreis/canonical-gov-proposals-order
branch
3 times, most recently
from
548465a to
972d817
Compare
joaosreis
force-pushed
the
joaosreis/canonical-gov-proposals-order
branch
from
972d817 to
764fb18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The order in which proposals were added must be preserved to properly reconstruct the ledger state.
This PR refactors the
gov/proposals/v0canonical namespace definition to also encode the order of each proposal.Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).