Fix failing cuddle test for Plutus data Constr.#5801
Fix failing cuddle test for Plutus data Constr.#5801koslambrou wants to merge 1 commit intomasterfrom
Conversation
lehins
left a comment
lehins
left a comment
There was a problem hiding this comment.
Good job at finding and fixing this. We've discussed this exact problem with @Soupstraw last week.
I am not sure if there is an actual ticket about this, but the solution we discussed was exactly what you implemented.
@koslambrou Could I please ask you for each PR to check all the relevant boxes in the PR description. I've explicitly unchecked the two that you missed in this one.
koslambrou
force-pushed
the
koslambrou/fix-cuddle-plutus-data
branch
4 times, most recently
from
5e5ccc5 to
4f0ac4c
Compare
Yes of course. I should have put it in Draft mode.
I looked for one, but didn't find one. |
lehins
left a comment
lehins
left a comment
There was a problem hiding this comment.
I should have put it in Draft mode.
No worries. It didn't take much time to review it.
I looked for one, but didn't find one.
Yeah, we should have created one, considering that this issue was known.
@Soupstraw Could I please ask you to review this PR, since you are the one who independently discovered it as well and investigated it quite a bit.
| -- @ | ||
| -- (toChoice $ tag 102 (arr [a VUInt, a $ arr [0 <+ a x]])) | ||
| -- @ | ||
| -- but 'toChoice' is not exported. |
There was a problem hiding this comment.
@Soupstraw Let me know if it makes sense to expose toChoice.
koslambrou
force-pushed
the
koslambrou/fix-cuddle-plutus-data
branch
2 times, most recently
from
2871db2 to
31c0294
Compare
Triggered by: ``` cabal run cardano-ledger-conway:test:tests -- --match "/Conway era-specific/CDDL/Huddle/Decoding fails when term is zapped/plutus_data: MemoBytes (PlutusData ConwayEra)/" --seed 1615161393 ``` The issue is that our list of allowed tags for the `Constr` data constructor of Plutus `Data` is not exhaustive enough. As per `PlutusCore.Data`, the allowed tags are 121-127, 1280-1400, and 102.
koslambrou
force-pushed
the
koslambrou/fix-cuddle-plutus-data
branch
from
31c0294 to
be2c9ef
Compare
2 participants
Description
Triggered by:
The issue is that our list of allowed tags for the
Constrdata constructor of PlutusDatais not exhaustive enough. As perPlutusCore.Data, the allowed tags are 121-127, 1280-1400, and 102.Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).