Start to re-organize test hierarchy: ImpSpec#5803
Conversation
|
How should we handle tests that are only applied starting from some era? For example, any plutus related tests should start from Alonzo. Should we have specialized typeclasses such as |
b0445ed to
ba81b08
Compare
615523d to
4c9b2c2
Compare
This question can be answered only in specific context of what type of test it is. This PR, is only concerned with |
There was a problem hiding this comment.
Love it! Much easier to understand which tests get called, at a small price of a few lines repeated.
So the pattern seems to be: eraImpSpec implementations have:
- an "opt-in" part - the
<Era>.<era>EraSpecificSpecones, and an - "auto-inheritable" part via
Imp.spec- which is defined as theImp.specof the previous era plus the new stuff that is to be inherited in future eras.
Looks good to me, just a few minor remarks.
6a494fd to
667c4cd
Compare
This commit introduces a general hierarchy for common era testing
667c4cd to
9cbe932
Compare
Description
This PR introduces a class base approach to enforcing common types of tests to be executed for all eras.
This approach also makes
EraSpecificSpecunnecessary, since it further expands the same concept.For now it only applies this approach to
ImpSpec, but other will follow in subsequent PRsFurthermore, it changes ImpSpec tests into consistent structure.
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).