Add ToJSON/FromJSON instances for each era transaction types#5818
Draft
koslambrou wants to merge 7 commits into
Draft
Add ToJSON/FromJSON instances for each era transaction types#5818koslambrou wants to merge 7 commits into
koslambrou wants to merge 7 commits into
Conversation
koslambrou
changed the title
koslambrou
force-pushed
the
koslambrou/golden-example-tx-json
branch
from
feac89b to
b53134a
Compare
koslambrou
force-pushed
the
koslambrou/golden-example-tx-each-era
branch
from
3ca2a75 to
fdc28e0
Compare
koslambrou
force-pushed
the
koslambrou/golden-example-tx-json
branch
2 times, most recently
from
f475885 to
87d9b46
Compare
koslambrou
force-pushed
the
koslambrou/golden-example-tx-each-era
branch
from
fdc28e0 to
b22c9a7
Compare
koslambrou
force-pushed
the
koslambrou/golden-example-tx-json
branch
from
87d9b46 to
e04de93
Compare
koslambrou
force-pushed
the
koslambrou/golden-example-tx-each-era
branch
from
b22c9a7 to
4d6655d
Compare
koslambrou
force-pushed
the
koslambrou/golden-example-tx-json
branch
from
e04de93 to
dc70149
Compare
koslambrou
force-pushed
the
koslambrou/golden-example-tx-each-era
branch
from
4d6655d to
8f6be2b
Compare
Collaborator
|
@koslambrou Could I please ask you to split out addition of golden files into a separate PR, this one is getting unwieldy |
koslambrou
force-pushed
the
koslambrou/golden-example-tx-each-era
branch
3 times, most recently
from
d726379 to
e00b05e
Compare
koslambrou
force-pushed
the
koslambrou/golden-example-tx-json
branch
from
dc70149 to
95ad341
Compare
koslambrou
force-pushed
the
koslambrou/golden-example-tx-each-era
branch
from
e00b05e to
06606e0
Compare
koslambrou
force-pushed
the
koslambrou/golden-example-tx-json
branch
from
95ad341 to
03c9c47
Compare
koslambrou
force-pushed
the
koslambrou/golden-example-tx-json
branch
2 times, most recently
from
32de64d to
bcabd9d
Compare
Add JSON serialisation instances for all types composing `Tx TopTx ShelleyEra`: - `cardano-ledger-core`: `TxIn`, `TxId`, `Metadatum`, `WitVKey`, `BootstrapWitness`, `Addr`, `RewardAccount`, `ScriptHash` (ToJSONKey/FromJSONKey) - `cardano-ledger-shelley`: `ShelleyTx`, `ShelleyTxBody`, `ShelleyTxWits`, `ShelleyTxAuxData`, `ShelleyTxOut`, `MultiSig`, `Update`, `ProposedPPUpdates` Conventions followed: - `kindObject` for sum types - `ToKeyValuePairs` + `deriving via KeyValuePairs` for product types - TxIn serialised as "TxIx#TxIx" text key - Map fields serialised as JSON objects (not lists of pairs) Add golden JSON test for `Tx TopTx ShelleyEra` at `eras/shelley/impl/golden/tx.json`.
koslambrou
force-pushed
the
koslambrou/golden-example-tx-each-era
branch
from
06606e0 to
88e4fda
Compare
koslambrou
force-pushed
the
koslambrou/golden-example-tx-json
branch
from
bcabd9d to
eb0e80c
Compare
koslambrou
force-pushed
the
koslambrou/golden-example-tx-json
branch
from
eb0e80c to
3e008d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add golden JSON tests for
Tx TopTx erafor each era ateras/<era>/impl/golden/tx.json.Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).