Post test failures summary to a PR comment as well as to CI#5838
Draft
neilmayhew wants to merge 4 commits into
Draft
Post test failures summary to a PR comment as well as to CI#5838neilmayhew wants to merge 4 commits into
neilmayhew wants to merge 4 commits into
Conversation
aae67b0 to
4800e43
Compare
Collaborator
|
Please make sure that it will not post any comments for draft PRs |
Contributor
Author
It's to enable a previous comment to be located and updated rather than adding a new comment. This cuts down the noise. The marker is placed in an HTML comment, so it doesn't show up in the rendered markdown. This was Claude's idea, and I think it's a good one. It originally called the action "Upsert PR Comment" but "upsert" is such an ugly word I chose to remove it 😄 |
Contributor
Author
Thanks for the reminder. I think you mentioned this when we first talked about it. I've pushed a commit that addresses this. |
Test Failures |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We already have a summary test failures being posted to the CI summary view. This posts a copy to a PR comment as well (if the CI is for a PR).
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).