Skip to content

Constrain the size of leios_certificate signers#5888

Draft
ch1bo wants to merge 1 commit into
leios-prototypefrom
ch1bo/constrain-leios-cert-signers
Draft

Constrain the size of leios_certificate signers#5888
ch1bo wants to merge 1 commit into
leios-prototypefrom
ch1bo/constrain-leios-cert-signers

Conversation

@ch1bo

@ch1bo ch1bo commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

The maximum length is determined by the maximum LeiosVoterId. As this is a Word16, the max number of entries is 65535 bits = 8192 bytes

Done as a separate PR to #5872, so it does not block that from merging.

TODO: This needs, either:

  • Check size in the decodeLeiosCert in cardano-crypto-leios and release as a 0.1.1 or even 0.2
  • Deprecate and move en-/decoders to a ledger package
    • Deprecate decodeLeiosCert in cardano-crypto-leios now and remove in a later 0.2
    • Add encodeLeiosCert/decodeLeiosCert that are size constrained and also support indefinite length bytes using cardano-ledger-binary

Checklist

  • Commits in meaningful sequence and with useful messages.
  • Tests added or updated when needed.
  • CHANGELOG.md files updated for packages with externally visible changes.
    NOTE: New section is never added with the code changes. (See RELEASING.md).
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary.
    NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
  • Code formatted (use scripts/fourmolize.sh).
  • Cabal files formatted (use scripts/cabal-format.sh).
  • CDDL files are up to date (use scripts/gen-cddl.sh)
  • hie.yaml updated (use scripts/gen-hie.sh).
  • Self-reviewed the diff.

@ch1bo ch1bo requested a review from a team as a code owner June 30, 2026 06:00
@ch1bo ch1bo marked this pull request as draft June 30, 2026 06:00
@ch1bo ch1bo mentioned this pull request Jun 30, 2026
10 tasks
Base automatically changed from ch1bo/cardano-crypto-leios to master June 30, 2026 08:05
@ch1bo ch1bo force-pushed the ch1bo/constrain-leios-cert-signers branch from 8618cd2 to 4ae4181 Compare June 30, 2026 09:41
@ch1bo ch1bo added the Leios Tickets related in some form to work on Leios label Jul 1, 2026
@ch1bo ch1bo changed the base branch from master to leios-prototype July 3, 2026 07:21
@ch1bo ch1bo force-pushed the ch1bo/constrain-leios-cert-signers branch from 4ae4181 to a68f977 Compare July 3, 2026 07:21
@ch1bo ch1bo force-pushed the leios-prototype branch from d108a4d to 17a4149 Compare July 3, 2026 07:41
@ch1bo ch1bo force-pushed the ch1bo/constrain-leios-cert-signers branch from a68f977 to eef6599 Compare July 3, 2026 15:36
The maximum length is determined by the maximum LeiosVoterId. As this is
a Word16, the max number of entries is 65535 bits = 8192 bytes
@ch1bo ch1bo force-pushed the ch1bo/constrain-leios-cert-signers branch from eef6599 to e099c92 Compare July 5, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Leios Tickets related in some form to work on Leios

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant