Skip to content

CI only#5527

Closed
mgmeier wants to merge 4 commits into
masterfrom
bench-8.6.0-pre
Closed

CI only#5527
mgmeier wants to merge 4 commits into
masterfrom
bench-8.6.0-pre

Conversation

@mgmeier

@mgmeier mgmeier commented Nov 4, 2023

Copy link
Copy Markdown
Contributor

Description

De-bump ouroboros-network-protocols to 0.5.2, which does not contain the hard-coded, not configurable chain sync idle timeout.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

@coot coot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgmeier mgmeier added the WIP Work In Progress (cannot be merged yet) label Nov 8, 2023
@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions Bot added the Stale label Dec 29, 2023
@mgmeier

mgmeier commented Feb 6, 2024

Copy link
Copy Markdown
Contributor Author

Triggering CI for benchmarking should use this branch / PR only: #5663

@mgmeier mgmeier closed this Feb 6, 2024
@mgmeier mgmeier deleted the bench-8.6.0-pre branch May 18, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Stale WIP Work In Progress (cannot be merged yet)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants