Skip to content

[Dijkstra] Refactor Epoch in Dijkstra to follow Conway#1244

Merged
carlostome merged 2 commits into
masterfrom
carlos/dijkstra-epoch
Jun 29, 2026
Merged

[Dijkstra] Refactor Epoch in Dijkstra to follow Conway#1244
carlostome merged 2 commits into
masterfrom
carlos/dijkstra-epoch

Conversation

@carlostome

Copy link
Copy Markdown
Collaborator

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Any semantic changes to the specifications are documented in CHANGELOG.md
  • Code is formatted according to CONTRIBUTING.md
  • Self-reviewed the diff

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the Dijkstra epoch-boundary specification to more closely follow the Conway structure, updating both the epoch transition-system definition and the accompanying computational/determinism proofs.

Changes:

  • Restructures EPOCH to use modular update records/modules (governance update, pre-/post-POOLREAP updates) and aligns the rule’s sub-transition ordering with Conway.
  • Updates stake-distribution and reward-update exposition/definitions to match the refactored epoch boundary flow.
  • Reworks EPOCH/NEWEPOCH computationality proofs to match the new EPOCH rule shape (including POOLREAP).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 11 comments.

File Description
src/Ledger/Dijkstra/Specification/Epoch.lagda.md Major refactor of the Dijkstra epoch boundary spec to mirror Conway structure; updates documentation and related helper functions.
src/Ledger/Dijkstra/Specification/Epoch/Properties/Computational.lagda.md Adjusts computationality/determinism proofs for EPOCH/NEWEPOCH to reflect the refactored transition rules.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/Ledger/Dijkstra/Specification/Epoch/Properties/Computational.lagda.md Outdated
Comment thread src/Ledger/Dijkstra/Specification/Epoch.lagda.md Outdated
Comment thread src/Ledger/Dijkstra/Specification/Epoch.lagda.md Outdated
Comment thread src/Ledger/Dijkstra/Specification/Epoch.lagda.md Outdated
Comment thread src/Ledger/Dijkstra/Specification/Epoch.lagda.md
Comment thread src/Ledger/Dijkstra/Specification/Epoch.lagda.md Outdated
Comment thread src/Ledger/Dijkstra/Specification/Epoch.lagda.md Outdated
Comment thread src/Ledger/Dijkstra/Specification/Epoch.lagda.md Outdated
Comment thread src/Ledger/Dijkstra/Specification/Epoch.lagda.md Outdated
@carlostome carlostome force-pushed the carlos/dijkstra-epoch branch from ef42015 to 04f6ff3 Compare June 26, 2026 14:36

@williamdemeo williamdemeo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. LGTM!

@carlostome carlostome force-pushed the carlos/dijkstra-epoch branch from 93aca61 to 29bfa71 Compare June 26, 2026 15:39
@carlostome carlostome merged commit de2fdf1 into master Jun 29, 2026
10 checks passed
@carlostome carlostome deleted the carlos/dijkstra-epoch branch June 29, 2026 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants