refactor(e2e): rename wait_for_* methods to improve readability and consistency

Has those functions are in the `WaitContext` we do not need to repeat
`wait_` in their names.

Author: Alenar

mithril-test-lab/mithril-end-to-end/src/scenario/full.rs

@@ -113,15 +113,15 @@ impl FullScenario {
     ) -> StdResult<()> {
         let leader_aggregator = infrastructure.leader_aggregator();
 
-        self.toolkit.wait.wait_for_enough_immutable(leader_aggregator).await?;
+        self.toolkit.wait.for_enough_immutable(leader_aggregator).await?;
         let chain_observer = leader_aggregator.chain_observer();
         let start_epoch = chain_observer.get_current_epoch().await?.unwrap_or_default();
 
         // Wait 4 epochs after start epoch for the aggregator to be able to bootstrap a genesis certificate
         let mut target_epoch = start_epoch + 4;
         self.toolkit
             .wait
-            .wait_for_aggregator_at_target_epoch(
+            .for_aggregator_at_target_epoch(
                 leader_aggregator,
                 target_epoch,
                 "minimal epoch for the aggregator to be able to bootstrap genesis certificate"
@@ -132,13 +132,13 @@ impl FullScenario {
             .exec
             .bootstrap_genesis_certificate(leader_aggregator)
             .await?;
-        self.toolkit.wait.wait_for_epoch_settings(leader_aggregator).await?;
+        self.toolkit.wait.for_epoch_settings(leader_aggregator).await?;
 
         // Wait 2 epochs before changing stake distribution, so that we use at least one original stake distribution
         target_epoch += 2;
         self.toolkit
             .wait
-            .wait_for_aggregator_at_target_epoch(
+            .for_aggregator_at_target_epoch(
                 leader_aggregator,
                 target_epoch,
                 "epoch after which the stake distribution will change".to_string(),
@@ -167,7 +167,7 @@ impl FullScenario {
         let mut target_epoch = start_epoch + 2;
         self.toolkit
             .wait
-            .wait_for_aggregator_at_target_epoch(
+            .for_aggregator_at_target_epoch(
                 aggregator,
                 target_epoch,
                 "epoch after which the protocol parameters will change".to_string(),
@@ -183,7 +183,7 @@ impl FullScenario {
 
         // Wait 6 epochs after protocol parameters update, so that we make sure that we use new protocol parameters as well as new stake distribution a few times
         target_epoch += 6;
-        self.toolkit.wait.wait_for_aggregator_at_target_epoch(
+        self.toolkit.wait.for_aggregator_at_target_epoch(
             aggregator,
             target_epoch,
             "epoch after which the certificate chain will be long enough to catch most common troubles with stake distribution and protocol parameters".to_string(),
@@ -204,7 +204,7 @@ impl FullScenario {
             target_epoch += 5;
             self.toolkit
                 .wait
-                .wait_for_aggregator_at_target_epoch(
+                .for_aggregator_at_target_epoch(
                     aggregator,
                     target_epoch,
                     "epoch after which the era switch will have triggered".to_string(),
@@ -217,7 +217,7 @@ impl FullScenario {
                 target_epoch += 5;
                 self.toolkit
                     .wait
-                    .wait_for_aggregator_at_target_epoch(
+                    .for_aggregator_at_target_epoch(
                         aggregator,
                         target_epoch,
                         "epoch after which the re-genesis on era switch will be completed"

mithril-test-lab/mithril-end-to-end/src/scenario/run_only.rs

@@ -38,15 +38,15 @@ impl RunOnlyScenario {
     ) -> StdResult<()> {
         let leader_aggregator = infrastructure.leader_aggregator();
 
-        self.toolkit.wait.wait_for_enough_immutable(leader_aggregator).await?;
+        self.toolkit.wait.for_enough_immutable(leader_aggregator).await?;
         let chain_observer = leader_aggregator.chain_observer();
         let start_epoch = chain_observer.get_current_epoch().await?.unwrap_or_default();
 
         // Wait 3 epochs after start epoch for the aggregator to be able to bootstrap a genesis certificate
         let target_epoch = start_epoch + 3;
         self.toolkit
             .wait
-            .wait_for_aggregator_at_target_epoch(
+            .for_aggregator_at_target_epoch(
                 leader_aggregator,
                 target_epoch,
                 "minimal epoch for the aggregator to be able to bootstrap genesis certificate"
@@ -57,7 +57,7 @@ impl RunOnlyScenario {
             .exec
             .bootstrap_genesis_certificate(leader_aggregator)
             .await?;
-        self.toolkit.wait.wait_for_epoch_settings(leader_aggregator).await?;
+        self.toolkit.wait.for_epoch_settings(leader_aggregator).await?;
 
         // Transfer some funds on the devnet to have some Cardano transactions to sign
         self.toolkit.exec.transfer_funds(infrastructure.devnet()).await?;

mithril-test-lab/mithril-end-to-end/src/toolkit/wait.rs

@@ -17,7 +17,7 @@ impl WaitToolkit {
         Self { context }
     }
 
-    pub async fn wait_for_enough_immutable(&self, aggregator: &Aggregator) -> StdResult<()> {
+    pub async fn for_enough_immutable(&self, aggregator: &Aggregator) -> StdResult<()> {
         info!("Waiting that enough immutable have been written in the devnet"; "aggregator" => aggregator.name());
 
         let db_directory = aggregator.db_directory();
@@ -44,7 +44,7 @@ impl WaitToolkit {
         }
     }
 
-    pub async fn wait_for_epoch_settings(
+    pub async fn for_epoch_settings(
         &self,
         aggregator: &Aggregator,
     ) -> StdResult<EpochSettingsMessage> {
@@ -80,7 +80,7 @@ impl WaitToolkit {
         }
     }
 
-    pub async fn wait_for_aggregator_at_target_epoch(
+    pub async fn for_aggregator_at_target_epoch(
         &self,
         aggregator: &Aggregator,
         target_epoch: Epoch,